Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Slow L-C2ST test fails locally #1178

Closed
manuelgloeckler opened this issue Jun 18, 2024 · 2 comments
Closed

Slow L-C2ST test fails locally #1178

manuelgloeckler opened this issue Jun 18, 2024 · 2 comments
Labels
bug Something isn't working

Comments

@manuelgloeckler
Copy link
Contributor

manuelgloeckler commented Jun 18, 2024

Describe the bug
L-C2ST (slow) tests fail locally.

FAILED tests/lc2st_test.py::test_lc2st_true_positiv_rate[LC2ST_NF] - AssertionError: LC2ST p-values too small, test should be accepted         at least 95.0% of the time, but was accepted         only 45.0% of the time.

To Reproduce

pytest tests/lc2st_test.py::test_lc2st_true_positiv_rate[LC2ST_NF]

On the current main, Python 3.11.7. (might dependents on python version)

This might be due to insufficient seeding or to strict tolerance for test.

@manuelgloeckler manuelgloeckler added the bug Something isn't working label Jun 18, 2024
@janfb
Copy link
Contributor

janfb commented Jun 25, 2024

@JuliaLinhart can you have a look at this please?

@janfb
Copy link
Contributor

janfb commented Aug 6, 2024

reason: for this test, the density estimator has to be off, but it was using too many simulations and became too good.

fixed with #1209

@janfb janfb closed this as completed Aug 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants