Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

log_prob_iid of MNLE not working #1136

Closed
michaeldeistler opened this issue Apr 9, 2024 · 0 comments · Fixed by #1203
Closed

log_prob_iid of MNLE not working #1136

michaeldeistler opened this issue Apr 9, 2024 · 0 comments · Fixed by #1203
Assignees
@janfb
Labels
bug Something isn't working

Comments

@michaeldeistler
Copy link
Contributor

michaeldeistler commented Apr 9, 2024 •
edited
Loading

In #1066, I did not update the log_prob_iid method. Instead, MNLE currently uses the standard log_prob() to sample here. For improved sampling speed we should revert to using log_prob_iid()
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@janfb janfb

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

refactor mixed density estimation sbi-dev/sbi
2 participants
@janfb @michaeldeistler