Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing packages when building the docs #1114

Closed
janfb opened this issue Mar 25, 2024 · 1 comment · Fixed by #1147
Closed

Missing packages when building the docs #1114

janfb opened this issue Mar 25, 2024 · 1 comment · Fixed by #1147
Labels
bug Something isn't working

Comments

@janfb
Copy link
Contributor

janfb commented Mar 25, 2024

When building the most recent docs I noticed several problems:

Upon running jupyter nbconvert --to markdown ../examples/*.ipynb --output-dir docs/examples/ && jupyter nbconvert --to markdown ../tutorials/*.ipynb --output-dir docs/tutorial/ as described in the wiki release workflow I get:

  • on macOS I get ModuleNotFoundError: No module named 'jupyter_contrib_nbextensions
  • after installing it via pip, I get a new one: ModuleNotFoundError: No module named 'notebook.base
  • solution: install a lower notebook version: pip install --upgrade notebook==6.4.12

Maybe we do need to add those to the dev requirements, but we should update the wiki or move this to the actual contribution.md

@janfb janfb added the bug Something isn't working label Mar 25, 2024
@Baschdl
Copy link
Contributor

Baschdl commented Mar 25, 2024

It apparently worked as it is right now in @famura's tests in #1063 (CI run) with basically the same command:

https://github.com/sbi-dev/sbi/pull/1063/files#diff-ea3ea8c9932adc7ba8161ceda844fedd43b006848ef1140c050cbd7ea0788a18R74-R78

Maybe it's once again dependent on the Python version. Python 3.8 installs an old version of notebook and you executed it with a newer Python version which then also installs a newer notebook version. Sounds quite plausible.

@janfb janfb linked a pull request Aug 6, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants