Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Using warning() instead of print()? #61

Open
paocorrales opened this issue May 2, 2023 · 0 comments
Open

Using warning() instead of print()? #61

paocorrales opened this issue May 2, 2023 · 0 comments

Comments

@paocorrales
Copy link

Hi! I'm happy to see this package alive again!

I've used some of the code to calculate the spi for another package and now we'll be able to add SPEI as a dependency. One thing I realize while doing some tests is that you are printing the warnings you collect in the spei() function using print() and that generates a lot of text in the console. I know you can avoid that by using verbose = FALSE but I think that using the warning() function instead of print() is a better practice, that way, R will recognize the text as a warning instead of random text.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant