Skip to content

Commit f86db3c

Browse files
committed
fix angular-pdf: add default for canvasid
- [x] add default to canvasid var - [x] delete not used if statament the default fix the statament on [line 43](https://github.com/sayanee/angularjs-pdf/blob/master/dist/angular-pdf.js#L43) return true when canvasid is not defined on html.
1 parent ac147c4 commit f86db3c

File tree

3 files changed

+5
-15
lines changed

3 files changed

+5
-15
lines changed

dist/angular-pdf.js

+2-7
Original file line numberDiff line numberDiff line change
@@ -38,13 +38,8 @@
3838
var pdfDoc = null;
3939
var pageNum = (attrs.page ? attrs.page : 1);
4040
var scale = attrs.scale > 0 ? attrs.scale : 1;
41-
var canvas;
42-
43-
if (attrs) {
44-
canvas = document.getElementById(attrs.canvasid);
45-
} else {
46-
canvas = document.getElementById('pdf-canvas');
47-
}
41+
var canvasid = attrs.canvasid || 'pdf-canvas';
42+
var canvas = document.getElementById(canvasid);
4843

4944
var creds = attrs.usecredentials;
5045
var ctx = canvas.getContext('2d');

dist/angular-pdf.min.js

+1-1
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

example/js/directives/angular-pdf.js

+2-7
Original file line numberDiff line numberDiff line change
@@ -38,13 +38,8 @@
3838
var pdfDoc = null;
3939
var pageNum = (attrs.page ? attrs.page : 1);
4040
var scale = attrs.scale > 0 ? attrs.scale : 1;
41-
var canvas;
42-
43-
if (attrs) {
44-
canvas = document.getElementById(attrs.canvasid);
45-
} else {
46-
canvas = document.getElementById('pdf-canvas');
47-
}
41+
var canvasid = attrs.canvasid || 'pdf-canvas';
42+
var canvas = document.getElementById(canvasid);
4843

4944
var creds = attrs.usecredentials;
5045
var ctx = canvas.getContext('2d');

0 commit comments

Comments
 (0)