fix angular-pdf: patch issue #67

- [X] use more verbose `pageToDisplay` instead `pageNum` - [X] on init use `pageToDiplay` instead 1 - [X] add a check on parse the attrs to ensure it's an int (else fallback to 1) fix #67
sayanee · Nov 19, 2015 · 1c963ec · 1c963ec
1 parent 6362966
commit 1c963ec
Show file tree

Hide file tree

Showing 3 changed files with 7 additions and 7 deletions.
diff --git a/dist/angular-pdf.js b/dist/angular-pdf.js
@@ -36,7 +36,7 @@
       link: function(scope, element, attrs) {
         var url = scope.pdfUrl;
         var pdfDoc = null;
-        var pageNum = (attrs.page ? attrs.page : 1);
+        var pageToDisplay = isFinite(attrs.page) ? parseInt(attrs.page) : 1;
         var pageFit = attrs.scale === 'page-fit';
         var scale = attrs.scale > 0 ? attrs.scale : 1;
         var canvasid = attrs.canvasid || 'pdf-canvas';
@@ -53,7 +53,7 @@
         });
 
         PDFJS.disableWorker = true;
-        scope.pageNum = pageNum;
+        scope.pageNum = pageToDisplay;
 
         scope.renderPage = function(num) {
           if (renderTask) {
@@ -190,7 +190,7 @@
           if (newVal !== '') {
             console.log('pdfUrl value change detected: ', scope.pdfUrl);
             url = newVal;
-            scope.pageToDisplay = 1;
+            scope.pageToDisplay = pageToDisplay;
             if (pdfLoaderTask) {
                 pdfLoaderTask.destroy().then(function () {
                     renderPDF();

diff --git a/dist/angular-pdf.min.js b/dist/angular-pdf.min.js
diff --git a/example/js/directives/angular-pdf.js b/example/js/directives/angular-pdf.js
@@ -36,7 +36,7 @@
       link: function(scope, element, attrs) {
         var url = scope.pdfUrl;
         var pdfDoc = null;
-        var pageNum = (attrs.page ? attrs.page : 1);
+        var pageToDisplay = isFinite(attrs.page) ? parseInt(attrs.page) : 1;
         var pageFit = attrs.scale === 'page-fit';
         var scale = attrs.scale > 0 ? attrs.scale : 1;
         var canvasid = attrs.canvasid || 'pdf-canvas';
@@ -53,7 +53,7 @@
         });
 
         PDFJS.disableWorker = true;
-        scope.pageNum = pageNum;
+        scope.pageNum = pageToDisplay;
 
         scope.renderPage = function(num) {
           if (renderTask) {
@@ -190,7 +190,7 @@
           if (newVal !== '') {
             console.log('pdfUrl value change detected: ', scope.pdfUrl);
             url = newVal;
-            scope.pageToDisplay = 1;
+            scope.pageToDisplay = pageToDisplay;
             if (pdfLoaderTask) {
                 pdfLoaderTask.destroy().then(function () {
                     renderPDF();