Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

timezone format does not match xml schema spec #154

Merged
merged 2 commits into from
Apr 27, 2011

Conversation

jkingdon
Copy link
Contributor

@jkingdon jkingdon commented Feb 8, 2011

Per http://www.w3.org/TR/xmlschema11-2/#dateTime

  1. UTC is represented by "Z", not GMT or UTC as Savon currently implements (depending on the ruby version, I think).
  2. timezone should be numeric, not something like "EST".

I tried to write specs for the numeric part but the ruby Time class (at least in 1.8.7) is pretty anemic and I didn't mess with trying to mock out the time zone.

@kimptoc
Copy link

kimptoc commented Apr 26, 2011

+1

@kimptoc
Copy link

kimptoc commented Apr 27, 2011

Although it seems the server I am talking too only accepts the Z based time - not a corrected local time, like

            <wsu:Created>2011-04-27T21:29:18+01:00</wsu:Created>

doh :(

rubiii added a commit that referenced this pull request Apr 27, 2011
timezone format does not match xml schema spec
@rubiii rubiii merged commit 700f797 into savonrb:master Apr 27, 2011
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants