Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Complete the path instead just names for include and require statements #77

Merged
merged 4 commits into from
Nov 16, 2023

Conversation

WilsonZiweiWang
Copy link
Collaborator

@WilsonZiweiWang WilsonZiweiWang commented Nov 14, 2023

It now completes the path up to the recipe folder:
image
image

@deribaucourt
Copy link
Member

deribaucourt commented Nov 15, 2023

It now completes the path up to the recipe folder: image image

In this screenshot, it would be better if the description on the left would contain the ".inc" extension.

Also but maybe that's low-priority/A4, you could list the .inc files inside the same directory before the ones that are not related.

@WilsonZiweiWang
Copy link
Collaborator Author

WilsonZiweiWang commented Nov 15, 2023

It now completes the path up to the recipe folder: image image

In this screenshot, it would be better if the description on the left would contain the ".inc" extension.

Also but maybe that's low-priority/A4, you could list the .inc files inside the same directory before the ones that are not related.

Added extension in the label and added the sort logic to prioritize the completion items that are under the same recipe folder as the current document

@WilsonZiweiWang WilsonZiweiWang merged commit 3e0d0b6 into staging Nov 16, 2023
3 checks passed
@WilsonZiweiWang WilsonZiweiWang deleted the Feature-10098-definition-provider branch November 16, 2023 14:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants