Fix: Change working directory for relative paths settings #76
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Settings like pathToBitbakeFolder should use "${workspaceFolder}" to
point to relative URIs. However if the user uses a relative path like
"./", the language server did resolve it properly, but not the client.
We now set the working directory to the workspace folder to be
consistent.
This does not produce unintended side effects according to our tests.
deribaucourt
force-pushed
the
relative-paths-settings
branch
from
9876485
to
e237f06
Compare
|
I confirmed that this fixed the parsing error on my side, could you also have a test for it? |
@WilsonZiweiWang I added a commit with the test |
idillon-sfl
approved these changes
Nov 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Settings like pathToBitbakeFolder should use "${workspaceFolder}" to point to relative URIs. However if the user uses a relative path like "./", the language server did resolve it properly, but not the client. We now set the working directory to the workspace folder to be consistent.
This does not produce unintended side effects according to our tests.