forked from yoctoproject/vscode-bitbake
-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Various changes: enhanced current features, added tests, fixed bugs and more #42
Merged
WilsonZiweiWang
merged 15 commits into
staging
from
Feature-10095-Improve-code-completion
Oct 31, 2023
Merged
Various changes: enhanced current features, added tests, fixed bugs and more #42
WilsonZiweiWang
merged 15 commits into
staging
from
Feature-10095-Improve-code-completion
Oct 31, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
WilsonZiweiWang
added
bug
Something isn't working
enhancement
New feature or request
labels
Oct 30, 2023
1. Use more precise name for the identifiers 2. Create completion items for variables on doc scan and use the previous ones as fallback
WilsonZiweiWang
force-pushed
the
Feature-10095-Improve-code-completion
branch
from
October 30, 2023 16:16
bd7e1f0
to
3cc1f3a
Compare
…a part of another word Now it only shows bitbake variable definition on global declaration syntax e.g. VAR in VAR = '123' but not in python VAR(){} or FOO = '${VAR}'
WilsonZiweiWang
force-pushed
the
Feature-10095-Improve-code-completion
branch
from
October 30, 2023 17:32
3cc1f3a
to
cd6bc9e
Compare
WilsonZiweiWang
changed the title
Various changes: enhancements and bug fixes
Various changes: enhanced current features, added tests, fixed bugs and more
Oct 30, 2023
deribaucourt
approved these changes
Oct 31, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please read the commit messages for the details in sequence.