Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Various changes: enhanced current features, added tests, fixed bugs and more #42

Merged
merged 15 commits into from
Oct 31, 2023

Conversation

WilsonZiweiWang
Copy link
Collaborator

@WilsonZiweiWang WilsonZiweiWang commented Oct 30, 2023

Please read the commit messages for the details in sequence.

@WilsonZiweiWang WilsonZiweiWang self-assigned this Oct 30, 2023
@WilsonZiweiWang WilsonZiweiWang added bug Something isn't working enhancement New feature or request labels Oct 30, 2023
@WilsonZiweiWang WilsonZiweiWang force-pushed the Feature-10095-Improve-code-completion branch from bd7e1f0 to 3cc1f3a Compare October 30, 2023 16:16
…a part of another word

Now it only shows bitbake variable definition on global declaration syntax
e.g. VAR in VAR = '123' but not in python VAR(){} or FOO = '${VAR}'
@WilsonZiweiWang WilsonZiweiWang force-pushed the Feature-10095-Improve-code-completion branch from 3cc1f3a to cd6bc9e Compare October 30, 2023 17:32
@WilsonZiweiWang WilsonZiweiWang changed the title Various changes: enhancements and bug fixes Various changes: enhanced current features, added tests, fixed bugs and more Oct 30, 2023
@WilsonZiweiWang WilsonZiweiWang marked this pull request as ready for review October 31, 2023 13:37
server/src/__tests__/fixtures/fixtures.ts Outdated Show resolved Hide resolved
server/src/server.ts Outdated Show resolved Hide resolved
server/src/BitBakeDocScanner.ts Show resolved Hide resolved
server/src/connectionHandlers/onCompletion.ts Outdated Show resolved Hide resolved
Copy link
Member

@deribaucourt deribaucourt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@WilsonZiweiWang WilsonZiweiWang merged commit 572db3b into staging Oct 31, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants