Feat: Add basic embedded support #38
Conversation
idillon-sfl
commented
Oct 26, 2023
idillon-sfl
commented
- Add basic hover and completion support for Bash and Python
- Save embedded documents on disk (we would rather not do it)
- Delete embedded documents on original document deletion
|
It would be nice if you could add some |
Good idea. I dit it |
idillon-sfl
force-pushed
the
add-embedded-support
branch
from
9d6edff
to
777ba07
Compare
| const originalPath = originalUriString.replace('file://', '') | ||
| const pathToEmbeddedDocumentsFolder = this.getPathToEmbeddedDocumentFolder(originalPath) | ||
| fs.mkdirSync(pathToEmbeddedDocumentsFolder, { recursive: true }) | ||
| const randomName = randomUUID() |
There was a problem hiding this comment.
Just to be sure, you always use the same random file for each language document, or is a new random file generated each parsing?
| fs.mkdirSync(pathToEmbeddedDocumentsFolder, { recursive: true }) | ||
| fs.writeFileSync(pathToEmbeddedDocument, embeddedDocumentContent) | ||
| } catch (error) { | ||
| logger.error('Failed to create embedded document:', error) |
There was a problem hiding this comment.
don't you want to exit the function or stop what you are doing at this point?
|
I think it would be nice if you could try to break down some commits a little bit since some commit messages don't completely cover every change under it. |
|
Be sure to handle |
idillon-sfl
force-pushed
the
add-embedded-support
branch
from
777ba07
to
738f0be
Compare
|
I am not forgetting about inline-python. Just not sure yet how to do it (but I have some ideas). I am now using promises for all the file system operations (create file, delete file, create directory, delete directory). I noticed the file deletion was async and it was giving inconsistent results for my tests. |
idillon-sfl
force-pushed
the
add-embedded-support
branch
2 times, most recently
from
2324bb0
to
dff3c2e
Compare
- Add basic hover and completion support for Bash and Python - Save embedded documents on disk (we would rather not do it) - Delete embedded documents on original document deletion
…nguage documents - This fixes tests that would give inconsistent results for file deletion - This handles the case where storagePath is undefined
idillon-sfl
force-pushed
the
add-embedded-support
branch
from
dff3c2e
to
e61f183
Compare
… languages support
idillon-sfl
force-pushed
the
add-embedded-support
branch
from
e599b53
to
b2cf131
Compare
