Refactor: Remove connection from class members etc #36
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
idillon-sfl
reviewed
Oct 25, 2023
WilsonZiweiWang
force-pushed
the
Feature-10098-definition-provider
branch
2 times, most recently
from
aae37f9
to
4b475d5
Compare
WilsonZiweiWang
force-pushed
the
Feature-10098-definition-provider
branch
from
4b475d5
to
ded6b0a
Compare
OutputParser and serverNotificationManager don't need to instantiate with connection. The connection can be set on start up. Use Analyzer's uriToAnalyzedDocument for returning document texts to replace documentAsTextMap onDefinitionHandler is in its own file for better testing
WilsonZiweiWang
force-pushed
the
Feature-10098-definition-provider
branch
from
ded6b0a
to
24d9d28
Compare
idillon-sfl
approved these changes
Oct 26, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
1.
OutputParserandserverNotificationManagerdon't need to instantiate withconnection. The connection can be set on start up. Plus, some classes only need one instance, I export one from the file where the class is defined to make sure everywhere else can reference the same instance.2.documentAsTextMapand Analyzer'suriToAnalyzedDocumenthave some similarities. They can be merged later. For now, they can both be members of the Analyzer2. Analyzer's
uriToAnalyzedDocumentalready has a TextDocument object, so I use it to replace thedocumentAsTextMap3.
onDefinitionHandleris put in its own file for better testing