forked from yoctoproject/vscode-bitbake
-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat: Add more completion items & Tests #26
Merged
WilsonZiweiWang
merged 16 commits into
staging
from
Feature-10095-Improve-code-completion
Oct 20, 2023
Merged
Feat: Add more completion items & Tests #26
WilsonZiweiWang
merged 16 commits into
staging
from
Feature-10095-Improve-code-completion
Oct 20, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added initial tests for completions and analyzer. Some changes are made to the server for the convenience of testing. Run |
deribaucourt
requested changes
Oct 17, 2023
WilsonZiweiWang
changed the title
Feat: Add more completion items
Feat: Add more completion items & Tests
Oct 17, 2023
WilsonZiweiWang
force-pushed
the
Feature-10095-Improve-code-completion
branch
from
October 17, 2023 16:18
dd58ee5
to
bf48fe4
Compare
1. Add reserved variables 2. Add reserved keywords (currently they include python and shell keywords) 3. Add simple snippets for bitbake recipe tasks
…e condition correction
1. Export an instance of analyzer from the source file and use this instance through out the program 2. Move the handler function for onCompletion event to its own file for the convenience of testing
WilsonZiweiWang
force-pushed
the
Feature-10095-Improve-code-completion
branch
from
October 18, 2023 14:59
bf48fe4
to
640dd78
Compare
This change touches the setting at the workspace level, if we are ok with this approach, I'll add tests accordingly. |
idillon-sfl
approved these changes
Oct 18, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me!
deribaucourt
requested changes
Oct 19, 2023
WilsonZiweiWang
force-pushed
the
Feature-10095-Improve-code-completion
branch
from
October 19, 2023 15:16
f581ef3
to
48c3bff
Compare
deribaucourt
approved these changes
Oct 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the following:
I keep the reserved variables as the fallback in case the docs scanner fails to read them in the bitbake folder.