Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run test in Travis-CI using Docker #775

Merged
merged 3 commits into from
Jul 11, 2017

Conversation

erozqba
Copy link
Contributor

@erozqba erozqba commented Jun 28, 2017

Fixes #758 by erozqba

Changes proposed in this pull request:

  • Update .travis.yml to run test using docker and docker-compose
  • ...
  • ...

Status

  • READY
  • HOLD
  • WIP (Work-In-Progress)

How to verify this change

Check Travis-CI build.

Deployment notes and migration

  • Migration is needed for this change

New translatable strings

Additional notes

If applicable, explain the rationale behind your change.

@erozqba erozqba force-pushed the issue_758 branch 8 times, most recently from 3503407 to 07ac23b Compare July 1, 2017 06:25
@coveralls
Copy link

Coverage Status

Coverage increased (+0.03%) to 95.353% when pulling 07ac23b on erozqba:issue_758 into bbc3954 on savoirfairelinux:dev.

@erozqba
Copy link
Contributor Author

erozqba commented Jul 1, 2017

@lingxiaoyang I have managed to make coveralls work inside the docker container, we have to pass some environment variables of TravisCI.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 95.326% when pulling f48cc2a on erozqba:issue_758 into bbc3954 on savoirfairelinux:dev.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.08%) to 95.405% when pulling 5883945 on erozqba:issue_758 into bbc3954 on savoirfairelinux:dev.

@lingxiaoyang
Copy link
Contributor

@erozqba Cool! Thank you for investigating the travis variables!

I think you included some changes of PR #762. We'll have to see if there's any change of #762 that is not included here, for example, (maybe) documentation.

@erozqba
Copy link
Contributor Author

erozqba commented Jul 5, 2017

@lingxiaoyang
I have included the changes of PR #762 that I found we must have as soon as possible, for the other changes we can continue the discussion in PR #762.
I have made a rebase over dev to fix the conflicts.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.01%) to 95.357% when pulling 7e75542 on erozqba:issue_758 into fe4c262 on savoirfairelinux:dev.

Copy link
Contributor

@lingxiaoyang lingxiaoyang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @erozqba. The changes look good.

I'll comment in PR #762 for remaining changes that are not included in your PR.

@lingxiaoyang lingxiaoyang merged commit 4a795a0 into savoirfairelinux:dev Jul 11, 2017
@erozqba erozqba mentioned this pull request Jul 27, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants