Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing the cardinal numbers and adding ordinal numbers support for Czech. #504

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

RuzickaJakub
Copy link

Fixes # by...

Changes proposed in this pull request:

  • When writing out numerals with words in the Czech language, we write each word separately. As stated in (only available in Czech): https://prirucka.ujc.cas.cz/?id=791
  • Ordinal numbers names support.

Status

  • READY
  • HOLD
  • WIP (Work-In-Progress)

How to verify this change

Fill out this section so that a reviewer can know how to verify your change.

Additional notes

If applicable, explain the rationale behind your change.

Copy link

@jan-kubica jan-kubica left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As another Czech native speaker, I confirm the proposed changes are correct.

@jan-kubica
Copy link

pinging @mrodriguezg1991

@mrodriguezg1991
Copy link
Contributor

pinging @mrodriguezg1991

@jan-kubica Thanks for contributing to the project, in order to add this changes all the test must pass, thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants