More options for SSH, GIT and SHELL #128
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The user `~/.ssh` config forwarding is now controlled by the `CQFD_NO_USER_SSH_CONFIG` environment variable. This allows finer control over the ssh configuration forwarding.
When running commands that use git, it is useful to have the user's .gitconfig available in the container. Mostly to have the user's name and email configured. For instance, when running Yocto's `devtool modify`, it will produce an error if the user's name and email are not configured. I chose to enable this new option by default, but it can be disabled with the `CQFD_NO_USER_GIT_CONFIG` environment variable. It is documented in the README.
When running `cqfd run -c` commands, the default login shell could be used instead of the one defined for `cqfd shell`. This was confusing and not configurable. The same shell will be always used, defined by the `CQFD_SHELL` environment variable. This notably overcomes a regression when using scripts that require bashisms. In the previous release, the default shell was `/bin/bash`, and is now `/bin/sh`. Users relying on bashisms still need to set `CQFD_SHELL` to `/bin/bash` in their environment. See issue #310.
deribaucourt
changed the title
deribaucourt
force-pushed
the
ssh-user-config-split
branch
from
9781fac
to
a8541a6
Compare
It can be useful for users to get access to the docker commands in order to tweak them, or dissect the options passed.
When running bash-completion's completion functions in zsh, the `_init_completion` and `_get_first_arg` functions are not defined in `bashcompinit`. Defining dummy functions allow using auto-completion in zsh although its not as accurate. Without _get_first_arg, the completion doesn't detail the options specific to that command and lists all of them.
deribaucourt
force-pushed
the
ssh-user-config-split
branch
from
a8541a6
to
bc52558
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The user
~/.sshconfig forwarding is now controlled by theCQFD_NO_USER_SSH_CONFIGenvironment variable. This allows finer control over the ssh configuration forwarding.