Default command to cqfd run, remove command and automatically init when needed
#106
Conversation
In order to have cqfd to run similarly to known tools, such as sudo, the cqfd run command has been removed as the default command is now "run". Tests have been updated automatically using the following commands: $ sed -i 's/cqfd run/cqfd/g' tests/0* $ sed -i -s 's/cqfd(.*) init/cqfd\1 --init/g' tests/0* $ sed -i -s 's/cqfd(.*) release/cqfd\1 --release/g' tests/0* $ sed -i -s 's/cqfd(.*) flavors/cqfd\1 --flavors/g' tests/0* $ sed -i -s 's/cqfd(.*) version/cqfd\1 --version/g' tests/0* and by manually running the test suite for missing $ cqfd.+ run commands.
Ballasi
force-pushed
the
sudoisation
branch
2 times, most recently
from
60591a8
to
99d36ec
Compare
As the cqfd --init command is going, in the future, to be ran automatically, work has been done to make it less instrusive. Rather than showing all of the Docker log, it just shows a throbber with the current step status, and shows the full log only if the docker build command failed.
As an effort to make cqfd run similarily to known tools, such as sudo, the docker image is automatically built if necessary rather than dying.
|
Thank you for this PR -- the proposed changes would certainly be improving the tool. As discussed, maybe this patch could be split into 2 (or 3) pull request. Notable advantages of this approach would be that:
|
| help Show this help text | ||
| --init Initialize project build container | ||
| --flavors List flavors from config file to stdout | ||
| --release Run argument(s) and release software |
There was a problem hiding this comment.
Should these 3 now be in the Options: section?
There was a problem hiding this comment.
The cqfd_run in the test files' name should probably be updated (maybe only cqfd instead?).
| usage | ||
| exit 1 | ||
| "--release") | ||
| has_to_release=true | ||
| ;; | ||
| *) |
There was a problem hiding this comment.
Could be out of scope, but can we support -- signifying the end of the options? Right now, cqfd -- ls doesn't work (shows the help message).
|
That's an interesting proposition to improve the tool, however, I think it is not the direction in which cqfd must evolve. Particularly, launching
In both cases, I think it is very important to notify the user that the Dockerfile has been changed. Writing |
As an effort to make cqfd run similarily to known tools, such as
sudo, work here has been done to:cqfd runautomatically without having to provide therunargumentcqfd (--)?initruncommand, it doesn't spam the user with anything pointless for the user