Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BooleanExpressionRule: refactor a logic of the distributive law as a rule for jbool library #1299

Closed
nulls opened this issue May 25, 2022 · 1 comment · Fixed by #1369
Closed

BooleanExpressionRule: refactor a logic of the distributive law as a rule for jbool library #1299

nulls opened this issue May 25, 2022 · 1 comment · Fixed by #1369
Assignees
@nulls
Labels
enhancement New feature or request
Milestone
1.2.0

Comments

@nulls
Copy link
Member

nulls commented May 25, 2022

Now BooleanExpressionRule applies the distributive law manipulating with a String and tokens directly.
The jbool library allows to write a custom rule (com.bpodgursky.jbool_expressions.rules.Rule).
Suggestion to refactor a logic for the distributive law as a rule for jbool library
@nulls nulls mentioned this issue May 25, 2022
Merged
1 task
@orchestr7 orchestr7 added the enhancement New feature or request label May 25, 2022
@orchestr7 orchestr7 added this to the 1.1.2 milestone May 25, 2022
@nulls nulls mentioned this issue Jun 16, 2022
Merged
@nulls
Copy link
Member Author

nulls commented Jun 16, 2022

implemented this rule in our source code, will create a PR to jbool library with this rule

@nulls nulls modified the milestones: 1.1.2, 1.1.1 Jun 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@nulls nulls

Labels
enhancement New feature or request
Projects
None yet
Milestone
1.2.0
Development

Successfully merging a pull request may close this issue.

Support DistributiveLaw as jbool.Rule saveourtool/diktat
2 participants
@nulls @orchestr7