Fix UConfigPropertyClass Reset to Default Crash

ryan-skabelund · ryan-skabelund · commit d4be77773bd4 · 2025-06-09T22:03:14.000-07:00
diff --git a/Mods/SML/Source/SML/Private/Configuration/Properties/ConfigPropertyClass.cpp b/Mods/SML/Source/SML/Private/Configuration/Properties/ConfigPropertyClass.cpp
@@ -79,8 +79,7 @@ bool UConfigPropertyClass::ResetToDefault_Implementation() {
     if (!CanResetNow() || !bDefaultValueInitialized) {
         return false;
     }
-    UClass* DefaultClassObject = DuplicateObject<UClass>(DefaultValue, this);
-    SetClassValue(DefaultClassObject);
+    SetClassValue(DefaultValue);
     MarkDirty();
     return true;
 }
diff --git a/Mods/SML/Source/SML/Public/Configuration/Properties/ConfigPropertyArray.h b/Mods/SML/Source/SML/Public/Configuration/Properties/ConfigPropertyArray.h
@@ -47,9 +47,9 @@ class SML_API UConfigPropertyArray : public UConfigProperty, public IConfigValue
     virtual void Deserialize_Implementation(const URawFormatValue* Value) override;
     virtual FConfigVariableDescriptor CreatePropertyDescriptor_Implementation(UConfigGenerationContext* Context, const FString& OuterPath) const override;
     virtual void FillConfigStruct_Implementation(const FReflectedObject& ReflectedObject, const FString& VariableName) const override;
-	virtual bool ResetToDefault_Implementation() override;
-	virtual bool IsSetToDefaultValue_Implementation() const override;
-	virtual FString GetDefaultValueAsString_Implementation() const override;
+    virtual bool ResetToDefault_Implementation() override;
+    virtual bool IsSetToDefaultValue_Implementation() const override;
+    virtual FString GetDefaultValueAsString_Implementation() const override;
     //End UConfigProperty
 
     //Begin IConfigValueDirtyHandlerInterface
diff --git a/Mods/SML/Source/SML/Public/Configuration/Properties/ConfigPropertyBool.h b/Mods/SML/Source/SML/Public/Configuration/Properties/ConfigPropertyBool.h
@@ -24,8 +24,8 @@ class SML_API UConfigPropertyBool : public UConfigProperty {
     virtual FConfigVariableDescriptor CreatePropertyDescriptor_Implementation(UConfigGenerationContext* Context, const FString& OuterPath) const override;
     virtual void FillConfigStruct_Implementation(const FReflectedObject& ReflectedObject, const FString& VariableName) const override;
     virtual bool ResetToDefault_Implementation() override;
-	virtual bool IsSetToDefaultValue_Implementation() const override;
-	virtual FString GetDefaultValueAsString_Implementation() const override;
+    virtual bool IsSetToDefaultValue_Implementation() const override;
+    virtual FString GetDefaultValueAsString_Implementation() const override;
     //End UConfigProperty
 
 private:
diff --git a/Mods/SML/Source/SML/Public/Configuration/Properties/ConfigPropertyClass.h b/Mods/SML/Source/SML/Public/Configuration/Properties/ConfigPropertyClass.h
@@ -50,9 +50,9 @@ class SML_API UConfigPropertyClass : public UConfigProperty {
     virtual void Deserialize_Implementation(const URawFormatValue* RawValue) override;
     virtual FConfigVariableDescriptor CreatePropertyDescriptor_Implementation(UConfigGenerationContext* Context, const FString& OuterPath) const override;
     virtual void FillConfigStruct_Implementation(const FReflectedObject& ReflectedObject, const FString& VariableName) const override;
-	virtual bool ResetToDefault_Implementation() override;
-	virtual bool IsSetToDefaultValue_Implementation() const override;
-	virtual FString GetDefaultValueAsString_Implementation() const override;
+    virtual bool ResetToDefault_Implementation() override;
+    virtual bool IsSetToDefaultValue_Implementation() const override;
+    virtual FString GetDefaultValueAsString_Implementation() const override;
     //End UConfigProperty
 
 private:
diff --git a/Mods/SML/Source/SML/Public/Configuration/Properties/ConfigPropertyFloat.h b/Mods/SML/Source/SML/Public/Configuration/Properties/ConfigPropertyFloat.h
@@ -23,9 +23,9 @@ class SML_API UConfigPropertyFloat : public UConfigProperty {
     virtual void Deserialize_Implementation(const URawFormatValue* Value) override;
     virtual FConfigVariableDescriptor CreatePropertyDescriptor_Implementation(UConfigGenerationContext* Context, const FString& OuterPath) const override;
     virtual void FillConfigStruct_Implementation(const FReflectedObject& ReflectedObject, const FString& VariableName) const override;
-	virtual bool ResetToDefault_Implementation() override;
-	virtual bool IsSetToDefaultValue_Implementation() const override;
-	virtual FString GetDefaultValueAsString_Implementation() const override;
+    virtual bool ResetToDefault_Implementation() override;
+    virtual bool IsSetToDefaultValue_Implementation() const override;
+    virtual FString GetDefaultValueAsString_Implementation() const override;
     //End UConfigProperty
 
 private:
diff --git a/Mods/SML/Source/SML/Public/Configuration/Properties/ConfigPropertyInteger.h b/Mods/SML/Source/SML/Public/Configuration/Properties/ConfigPropertyInteger.h
@@ -23,9 +23,9 @@ class SML_API UConfigPropertyInteger : public UConfigProperty {
 	virtual void Deserialize_Implementation(const URawFormatValue* Value) override;
     virtual FConfigVariableDescriptor CreatePropertyDescriptor_Implementation(UConfigGenerationContext* Context, const FString& OuterPath) const override;
     virtual void FillConfigStruct_Implementation(const FReflectedObject& ReflectedObject, const FString& VariableName) const override;
-	virtual bool ResetToDefault_Implementation() override;
-	virtual bool IsSetToDefaultValue_Implementation() const override;
-	virtual FString GetDefaultValueAsString_Implementation() const override;
+    virtual bool ResetToDefault_Implementation() override;
+    virtual bool IsSetToDefaultValue_Implementation() const override;
+    virtual FString GetDefaultValueAsString_Implementation() const override;
 	//End UConfigProperty
 
 private:
diff --git a/Mods/SML/Source/SML/Public/Configuration/Properties/ConfigPropertyString.h b/Mods/SML/Source/SML/Public/Configuration/Properties/ConfigPropertyString.h
@@ -23,9 +23,9 @@ class SML_API UConfigPropertyString : public UConfigProperty {
     virtual void Deserialize_Implementation(const URawFormatValue* Value) override;
     virtual FConfigVariableDescriptor CreatePropertyDescriptor_Implementation(UConfigGenerationContext* Context, const FString& OuterPath) const override;
     virtual void FillConfigStruct_Implementation(const FReflectedObject& ReflectedObject, const FString& VariableName) const override;
-	virtual bool ResetToDefault_Implementation() override;
-	virtual bool IsSetToDefaultValue_Implementation() const override;
-	virtual FString GetDefaultValueAsString_Implementation() const override;
+    virtual bool ResetToDefault_Implementation() override;
+    virtual bool IsSetToDefaultValue_Implementation() const override;
+    virtual FString GetDefaultValueAsString_Implementation() const override;
     //End UConfigProperty
 
 private:

Original file line number	Diff line number	Diff line change
`@@ -79,8 +79,7 @@ bool UConfigPropertyClass::ResetToDefault_Implementation() {`
`79`	`79`	`if (!CanResetNow() \|\| !bDefaultValueInitialized) {`
`80`	`80`	`return false;`
`81`	`81`	`}`
`82`		`- UClass* DefaultClassObject = DuplicateObject<UClass>(DefaultValue, this);`
`83`		`- SetClassValue(DefaultClassObject);`
	`82`	`+ SetClassValue(DefaultValue);`
`84`	`83`	`MarkDirty();`
`85`	`84`	`return true;`
`86`	`85`	`}`