-
Notifications
You must be signed in to change notification settings - Fork 56
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support saving images which are identified by SHA rather than tag #140
base: main
Are you sure you want to change the base?
Conversation
It would be nice if we can pass those sha to the cache action to pick what we want to cache no? |
@MostefaKamalLala That sounds like a separate feature - there's an issue for it already, #121, as you've discovered. |
Docker images saved by hash, i.e. kind cluster image, don't work with satackey docker layer caching, causing build to fail. See satackey/action-docker-layer-caching#140 Remove the broken plugin from use.
I worked out how to use it the other day - the secret was to enable GitHub Actions on my fork, so it could automatically produce a uses: ZimbiX/action-docker-layer-caching@fix-error-cannot-use-import-statement-outside-a-module-release |
@satackey This is confirmed ready to review and merge |
@ezequielgarcia We're still waiting for @satackey to review. In the meantime, you can use my fork with the line above =) |
@satackey Are you still planning on maintaining this project? 🙏 |
Hopefully resolves #17 and #49.
Images can be pulled by SHA, but these don't get tagged, e.g.:
We can't then use the repo plus non-existent tag to identify it in the call to
docker save
. Instead, we can use the image ID, e.g.:I'm fetching these details via:
This project badly needs some tests. In order to test this locally, I had to do so rather hackily.
I haven't tested out restoring yet. Putting this up here to share my progress.