-
Notifications
You must be signed in to change notification settings - Fork 157
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Deprecation plans #220
Comments
Is there any existing or potential replacement for this gem for Rails, apart from changing things completely and compiling css with Webpack using Dart-Sass? Currently there seems to be a problem with a long compile time (approx. 2 minutes) and this has been going on for almost 2 years. There are suggestions for solutions like amalgamate or shipping precompiled , but from what I can see they are not merged and updated for a long time. |
|
@cyclotron3k sassc-ruby does not use the sassc executable. It uses the libsass C library through FFI. The replacement will more likely be dart-sass-embedded, for which a Ruby host is in progress at https://github.com/ntkme/sass-embedded-host-ruby |
@stof any idea on how use this gem in the assets pipeline? |
New apps are recommended to migrate to sass-embedded. For existing apps you can use sassc-embedded as a drop in replacement for sassc. See https://github.com/ntkme/sassc-embedded-shim-ruby for details. |
I think https://github.com/rails/dartsass-rails is the official replacement from Rails' point of view. |
The rails team is moving away from sprockets. Doing so comes with the cost of missing features, such as custom sass functions in Ruby that many existing projects rely on. The purpose of the shim is to help existing projects to migrate. Update: dartsass-rails now uses the dart-sass binary provided by sass-embedded gem so it's always up to update. |
I've have made PR #240 which merges @ntkme 's dart-sass shim code into this repo. That PR branch is now being used successfully at TableCheck and Discourse. I'd like to propose to nominate new maintainers for this gem so that we can continue to support it. I'm willing to be an interim maintainer if no one else is available. |
@johnnyshields do you plan to keep updating your current dart-sass branch? I'd convert it to a full fork, with open issues, and merge it to your main branch and start telling people to use it. |
OK I'll handle that today. Thanks! |
dartsass-ruby gem is released! 🎉 |
Looks like we also need to fork sassc-rails. I'll get on that now. |
Here is my comment from a different but similar issue regarding the effort of replace sassc completely with my shim: TL;DR: If you care about the experience, please directly integrate with The main problem is that many apps have There are quite a few other issues. Dart Sass made the decision to revamp the importer behavior and which is very different from My take is that The shim is not meant to be the long term solution, as the While it is nice to everyone else that you want to maintain an obsolete technology, promoting it as a permanent solution is just a step backward. |
Yep, that's exactly what the new dartsass-ruby gem does.
It would be good document the known issues and put it in the gem's README. Users should be aware.
From my perspective:
It would be great if you could join as a co-maintainer, or I can transfer full ownership to you if you prefer. I just want a released gem that we can use today and improve in the future. (To be clear: I don't actually want to maintain these gems, I would much prefer if someone else did it!) |
What I meant is to completely rewrite sprockets sass integration to directly use sass-embedded. There will be a few breaking changes in terms of features, but otherwise when Dart Sass 2.0 is released the shim will no longer work and it will actually be impossible to shim at that point due to already planned breaking changed. This is nothing but buy you time before that happens. |
OK, noted. Hopefully someone can refactor dartsass-sprockets when that time comes and release it as a new major version. Are the new APIs ready in |
@johnnyshields See the documentation https://rubydoc.info/gems/sass-embedded/Sass, this Ruby API is an exact mirror of the official new JS API. |
OK I understand now. Your shim adds support for SassC features that were intentionally dropped or made more strict in Dart Sass. So users will have no choice but to upgrade their SCSS files. I will work to sunset the shim code and make it so that |
Now that libsass is deprecated, what are the plans for this project ? Should it be marked as deprecated as well ?
The text was updated successfully, but these errors were encountered: