From 2ba02164358e1402e74740fd500a0722974c6b40 Mon Sep 17 00:00:00 2001 From: Nick Schonning Date: Fri, 21 Apr 2023 16:54:50 -0400 Subject: [PATCH 1/3] feat: Node 20 support --- .github/workflows/alpine.yml | 1 + .github/workflows/linux.yml | 9 ++++----- .github/workflows/macos.yml | 1 + .github/workflows/windows.yml | 1 + README.md | 1 + appveyor.yml | 3 +++ lib/extensions.js | 1 + package.json | 2 +- 8 files changed, 13 insertions(+), 6 deletions(-) diff --git a/.github/workflows/alpine.yml b/.github/workflows/alpine.yml index c918e3e69..08e0faffd 100644 --- a/.github/workflows/alpine.yml +++ b/.github/workflows/alpine.yml @@ -20,6 +20,7 @@ jobs: # - 16 # - 18 # - 19 + - 20 steps: - name: Install Alpine build tools diff --git a/.github/workflows/linux.yml b/.github/workflows/linux.yml index 4d41f6567..66f0ff196 100644 --- a/.github/workflows/linux.yml +++ b/.github/workflows/linux.yml @@ -13,11 +13,6 @@ jobs: strategy: fail-fast: false matrix: - node: - - 14 - - 16 - - 18 - include: - node: 14 gcc: "gcc-6" @@ -35,6 +30,10 @@ jobs: gcc: "gcc-8" gpp: "g++-8" os: ubuntu-20.04 + - node: 20 + gcc: "gcc-10" + gpp: "g++-10" + os: ubuntu-22.04 steps: diff --git a/.github/workflows/macos.yml b/.github/workflows/macos.yml index e03df1faa..861c7e954 100644 --- a/.github/workflows/macos.yml +++ b/.github/workflows/macos.yml @@ -18,6 +18,7 @@ jobs: - 16 - 18 - 19 + - 20 steps: - uses: actions/checkout@v3 diff --git a/.github/workflows/windows.yml b/.github/workflows/windows.yml index 0ee040ef0..6c44bb087 100644 --- a/.github/workflows/windows.yml +++ b/.github/workflows/windows.yml @@ -18,6 +18,7 @@ jobs: - 16 - 18 - 19 + - 20 architecture: - x64 diff --git a/README.md b/README.md index f08caf777..981ad61b9 100644 --- a/README.md +++ b/README.md @@ -17,6 +17,7 @@ Below is a quick guide for minimum and maximum supported versions of node-sass: NodeJS | Supported node-sass version | Node Module --------|-----------------------------|------------ +Node 20 | 9.0+ | 115 Node 19 | 8.0+ | 111 Node 18 | 8.0+ | 108 Node 17 | 7.0+, <8.0 | 102 diff --git a/appveyor.yml b/appveyor.yml index 4a6837ddd..01407cba4 100644 --- a/appveyor.yml +++ b/appveyor.yml @@ -45,6 +45,9 @@ - nodejs_version: 19 GYP_MSVS_VERSION: 2019 APPVEYOR_BUILD_WORKER_IMAGE: Visual Studio 2019 + - nodejs_version: 20 + GYP_MSVS_VERSION: 2019 + APPVEYOR_BUILD_WORKER_IMAGE: Visual Studio 2019 install: diff --git a/lib/extensions.js b/lib/extensions.js index 4622f5dc5..24314b8bd 100644 --- a/lib/extensions.js +++ b/lib/extensions.js @@ -84,6 +84,7 @@ function getHumanNodeVersion(abi) { case 102: return 'Node.js 17.x'; case 108: return 'Node.js 18.x'; case 111: return 'Node.js 19.x'; + case 115: return 'Node.js 20.x'; default: return false; } } diff --git a/package.json b/package.json index 7139aa80e..05faee8de 100644 --- a/package.json +++ b/package.json @@ -1,6 +1,6 @@ { "name": "node-sass", - "version": "8.0.0", + "version": "9.0.0", "libsass": "3.5.5", "description": "Wrapper around libsass", "license": "MIT", From 09917ee592f84f00f7f5b096a28ccb7313f06714 Mon Sep 17 00:00:00 2001 From: Nick Schonning Date: Fri, 21 Apr 2023 17:06:04 -0400 Subject: [PATCH 2/3] ci: update stalled Alpine/Linux jobs --- .github/workflows/alpine.yml | 7 +++---- .github/workflows/linux.yml | 4 ++-- 2 files changed, 5 insertions(+), 6 deletions(-) diff --git a/.github/workflows/alpine.yml b/.github/workflows/alpine.yml index 08e0faffd..109dce1ab 100644 --- a/.github/workflows/alpine.yml +++ b/.github/workflows/alpine.yml @@ -16,10 +16,9 @@ jobs: matrix: node: - 14 - # Node 16+ are perma-red for the tests right now - # - 16 - # - 18 - # - 19 + - 16 + - 18 + - 19 - 20 steps: diff --git a/.github/workflows/linux.yml b/.github/workflows/linux.yml index 66f0ff196..a248e18b5 100644 --- a/.github/workflows/linux.yml +++ b/.github/workflows/linux.yml @@ -17,11 +17,11 @@ jobs: - node: 14 gcc: "gcc-6" gpp: "g++-6" - os: ubuntu-18.04 + os: ubuntu-20.04 - node: 16 gcc: "gcc-8" gpp: "g++-8" - os: ubuntu-18.04 + os: ubuntu-20.04 - node: 18 gcc: "gcc-8" gpp: "g++-8" From ab10a63b3f561118aba5341d0e24a4d759a0affe Mon Sep 17 00:00:00 2001 From: Nick Schonning Date: Fri, 21 Apr 2023 17:32:10 -0400 Subject: [PATCH 3/3] feat: drop Node 14 --- .github/workflows/alpine.yml | 1 - .github/workflows/linux.yml | 4 ---- .github/workflows/macos.yml | 1 - .github/workflows/windows.yml | 1 - README.md | 2 +- appveyor.yml | 3 --- package.json | 2 +- 7 files changed, 2 insertions(+), 12 deletions(-) diff --git a/.github/workflows/alpine.yml b/.github/workflows/alpine.yml index 109dce1ab..188076059 100644 --- a/.github/workflows/alpine.yml +++ b/.github/workflows/alpine.yml @@ -15,7 +15,6 @@ jobs: fail-fast: false matrix: node: - - 14 - 16 - 18 - 19 diff --git a/.github/workflows/linux.yml b/.github/workflows/linux.yml index a248e18b5..b0b3fc9dc 100644 --- a/.github/workflows/linux.yml +++ b/.github/workflows/linux.yml @@ -14,10 +14,6 @@ jobs: fail-fast: false matrix: include: - - node: 14 - gcc: "gcc-6" - gpp: "g++-6" - os: ubuntu-20.04 - node: 16 gcc: "gcc-8" gpp: "g++-8" diff --git a/.github/workflows/macos.yml b/.github/workflows/macos.yml index 861c7e954..a3135c242 100644 --- a/.github/workflows/macos.yml +++ b/.github/workflows/macos.yml @@ -14,7 +14,6 @@ jobs: fail-fast: false matrix: node: - - 14 - 16 - 18 - 19 diff --git a/.github/workflows/windows.yml b/.github/workflows/windows.yml index 6c44bb087..a546e872f 100644 --- a/.github/workflows/windows.yml +++ b/.github/workflows/windows.yml @@ -14,7 +14,6 @@ jobs: fail-fast: false matrix: node: - - 14 - 16 - 18 - 19 diff --git a/README.md b/README.md index 981ad61b9..125dee83f 100644 --- a/README.md +++ b/README.md @@ -23,7 +23,7 @@ Node 18 | 8.0+ | 108 Node 17 | 7.0+, <8.0 | 102 Node 16 | 6.0+ | 93 Node 15 | 5.0+, <7.0 | 88 -Node 14 | 4.14+ | 83 +Node 14 | 4.14+, <9.0 | 83 Node 13 | 4.13+, <5.0 | 79 Node 12 | 4.12+, <8.0 | 72 Node 11 | 4.10+, <5.0 | 67 diff --git a/appveyor.yml b/appveyor.yml index 01407cba4..17e95edc6 100644 --- a/appveyor.yml +++ b/appveyor.yml @@ -33,9 +33,6 @@ environment: SKIP_SASS_BINARY_DOWNLOAD_FOR_CI: true matrix: - - nodejs_version: 14 - GYP_MSVS_VERSION: 2017 - APPVEYOR_BUILD_WORKER_IMAGE: Visual Studio 2017 - nodejs_version: 16 GYP_MSVS_VERSION: 2019 APPVEYOR_BUILD_WORKER_IMAGE: Visual Studio 2019 diff --git a/package.json b/package.json index 05faee8de..6abfe1dc5 100644 --- a/package.json +++ b/package.json @@ -16,7 +16,7 @@ "url": "http://andrew.github.com" }, "engines": { - "node": ">=14" + "node": ">=16" }, "main": "lib/index.js", "nodeSassConfig": {