Skip to content
This repository has been archived by the owner on Jul 24, 2024. It is now read-only.

Release 3.0.0-beta.6 #873

Closed
7 of 8 tasks
xzyfer opened this issue Apr 20, 2015 · 18 comments
Closed
7 of 8 tasks

Release 3.0.0-beta.6 #873

xzyfer opened this issue Apr 20, 2015 · 18 comments

Comments

@xzyfer
Copy link
Contributor

xzyfer commented Apr 20, 2015

This is tracking the tasks required to release 3.0.0-beta.6

Optional

  • build SmartOS binaries /cc @geekrohit @candid
  • build FreeBSD binaries /cc @saper

@am11 @saper @geekrohit @candid could you please assist in creating the relevant binaries and PR'ing node-sass-binaries?

You can use sass/node-sass-binaries#58 as a template for said PR. We require binaries for node 0.10.latest, node 0.12.latest, iojs 1.0.0, iojs 1.7.1 on both 32 and 64 bit OSes. I recommend using nvm to manage the multiple node/iojs versions.

When this issue is closed 3.0.0-beta.6 will be released.

@xzyfer xzyfer added this to the 3.0 milestone Apr 20, 2015
@xzyfer
Copy link
Contributor Author

xzyfer commented Apr 20, 2015

x-referencing #858 #713 sindresorhus/grunt-sass#203

@djensen47
Copy link

Out of curiosity, why are SmartOS and FreeBSD optional? Or is it just optional for Beta 6?

@Jakobud
Copy link

Jakobud commented Apr 20, 2015

Just curios, why doesn't node-sass version numbers stay consistent with the libsass version that is used? For example if libsass is at 3.2 and node-sass using that version, shouldn't node-sass say it's also version 3.2? Just for consistency sake? I came to this issue because when I was looking at my version of node-sass I had installed I saw 3.0.0 and my first thought was "it's using libsass 3.0?".

@xzyfer
Copy link
Contributor Author

xzyfer commented Apr 20, 2015

Out of curiosity, why are SmartOS and FreeBSD optional? Or is it just optional for Beta 6?

@djensen47 for this beta, and potentially the initial stable release. I don't believe it makes sense (or fair?) to hold up a release waiting on FreeBSD or SmartOS binaries for a couple reasons.

  • support for them is either very new or non-existent in current releases
  • as a results using is on those OSes is small in comparison
  • we don't currently have anyone owning the responsibility to build those binaries

Until we can automate the building of FreeBSD and SmartOS binaries, or someone volunteers to be responsible for doing so, it's hard to justify holding everyone else behind.

To be clear we can trivially add these binaries as soon as they become available.

If this is something you want to help with we're more than happy to make this a priority :)

@xzyfer
Copy link
Contributor Author

xzyfer commented Apr 20, 2015

why doesn't node-sass version numbers stay consistent with the libsass version that is used

@Jakobud these are two distinct projects. Node-sass adheres strictly to semver. We desire the freedom to make improvements or breaking changes to our user face API independent of libSass releases.

Our relationship to libSass is analogous to grunt-sass' or gulp-sass' relationship to node-sass.

@mgreter
Copy link
Contributor

mgreter commented Apr 21, 2015

I fully agree with @xzyfer, as it would tightly couple the release cycles of both projects, and that is not what you want, neither as a developer nor as a consumer! I agree, try to keep it somewhat close if possible, but semver goes first!

@xzyfer
Copy link
Contributor Author

xzyfer commented Apr 21, 2015

We're currently waiting on @am11 to either building our linux binaries, or instruct me on his process. There is some complication around our linux binaries as we need to support relatively old distributions.

@xzyfer
Copy link
Contributor Author

xzyfer commented Apr 21, 2015

x-referencing #850

@rohit-saharan
Copy link

On it. Will see if I can setup a jenkins task to do this and push. What say @xzyfer ?

@xzyfer
Copy link
Contributor Author

xzyfer commented Apr 21, 2015

Push to what exactly @geekrohit?

Ideally we need SmartOS binaries for node 0.10.38, 0.12.0, iojs 1.0.4, 1.8.1 on both 64 and 32 bit. Binaries should be submitted as PR to https://github.com/sass/node-sass-binaries.

Here is a good template to follow sass/node-sass-binaries#58

I recommend using nsm to manage multiple node versions (if that's an option).

@xzyfer
Copy link
Contributor Author

xzyfer commented Apr 21, 2015

I will be spending considerable time on automating this process for the next minor release.
For now I'm keen to get this release out asap.

@rohit-saharan
Copy link

Yeah, will make a repo like that and submit for PR. Thats what I meant by using jenkins for doing that.

@xzyfer
Copy link
Contributor Author

xzyfer commented Apr 21, 2015

Oh ok, great. I currently use docker for as much as possible. I use a minor variation of this for building linux binaries - https://gist.github.com/am11/1529b2458b1a1f4bdba8

@saper
Copy link
Member

saper commented Apr 21, 2015

Which commit should I base the FreeBSD ports on? Currently using 8b7ad43 for testing

@xzyfer
Copy link
Contributor Author

xzyfer commented Apr 21, 2015

I'll be creating the 3.0.0-beta.6 tag in minutes.

@frvge
Copy link

frvge commented Apr 21, 2015

Very interested in the FreeBSD binaries here.

@chriseppstein
Copy link
Contributor

👍

....

OMG I'm that guy.

@xzyfer
Copy link
Contributor Author

xzyfer commented Apr 22, 2015

This has been released as v3.0.0-beta.7.

There was an npm hiccup on publishing v3.0.0-beta.6 so I have unpublished. My fault.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

8 participants