Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unbreak eyeglass asset helper #2197

Closed
xzyfer opened this issue Sep 28, 2016 · 2 comments
Closed

Unbreak eyeglass asset helper #2197

xzyfer opened this issue Sep 28, 2016 · 2 comments
Milestone

Comments

@xzyfer
Copy link
Contributor

xzyfer commented Sep 28, 2016

#2171 introduced a regression that is causing many eyeglass tests to fail for the asset helper.

assets
    ✓ should give an error when an asset is not found (82ms)
    1) should let an app refer to it's own assets
    ✓ asset importer should delegate to custom importer
    2) should import a module's assets
    3) should import own assets from within a module
    4) should allow httpPrefix for app assets
    5) should allow a global httpPrefix for all assets
    6) should allow a relative URLs
    7) should allow a relative URLs when httpRoot is set
    8) should nest a asset path entry http prefix inside the global httpPrefix
    ✓ register-asset() works
    9) allows url mangling
    10) allows installing assets
    11) allows installing assets
    12) handles asset installer errors
    13) should not install into the httpRoot
    ✓ should manually install assets
    ✓ should handle an installer error
    14) should handle undefined file being passed to install
    15) should handle an error in a resolver
    16) should handle a sass error in a resolver
    ✓ should give an error when a module does not have assets
    ✓ should give an error when a module does not exist
    ✓ can pretty print an asset path entry
    ✓ can assign custom glob opts to an asset path entry
    ✓ asset path entries must be directories
    17) should allow uri fragments
    18) asset-uri should return the uri only, not wrapped in url()
    19) support assets specified via options
    20) should normalize URI directory traversal
    21) should support odd character in file names

  136 passing (2s)
  1 pending
  21 failing

@chriseppstein I don't know much about the internals of eyeglass. I would appreciate some help from yourself or @eoneill to get a reduced test case together.

I believe this is the last blocker for a 3.4RC.

@xzyfer
Copy link
Contributor Author

xzyfer commented Oct 4, 2016

Patch provided upstream - linkedin/eyeglass#145

@xzyfer
Copy link
Contributor Author

xzyfer commented Oct 18, 2016

Fixed in [email protected]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant