We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Hello, I'm trying to migrate a script from sass to sass-embedded and can't use SassBoolean anymore. The script tries to identify the type with: if (value instanceof SassBoolean) { (...) } At runtime, the following error is thrown: Error: TypeError: Right-hand side of 'instanceof' is not an object I realized SassBoolean is an interface and not a class: embedded-host-node/lib/src/value/boolean.ts Line 15 in 248437e export interface SassBoolean extends Value { Therefore, it is not present here in the compiled index.js along sassFalse and sassTrue: var boolean_2 = require("./src/value/boolean"); Object.defineProperty(exports, "sassFalse", { enumerable: true, get: function () { return boolean_2.sassFalse; } }); Object.defineProperty(exports, "sassTrue", { enumerable: true, get: function () { return boolean_2.sassTrue; } }); Should one use sassFalse and sassTrue instead ? As is, SassBoolean still breaks usage of sass-embedded as drop-in replacement, as mentioned by @rvock.
Hello,
I'm trying to migrate a script from sass to sass-embedded and can't use SassBoolean anymore.
sass
sass-embedded
SassBoolean
The script tries to identify the type with:
if (value instanceof SassBoolean) { (...) }
At runtime, the following error is thrown:
Error: TypeError: Right-hand side of 'instanceof' is not an object
I realized SassBoolean is an interface and not a class:
embedded-host-node/lib/src/value/boolean.ts
Line 15 in 248437e
Therefore, it is not present here in the compiled index.js along sassFalse and sassTrue:
index.js
var boolean_2 = require("./src/value/boolean"); Object.defineProperty(exports, "sassFalse", { enumerable: true, get: function () { return boolean_2.sassFalse; } }); Object.defineProperty(exports, "sassTrue", { enumerable: true, get: function () { return boolean_2.sassTrue; } });
Should one use sassFalse and sassTrue instead ?
sassFalse
sassTrue
As is, SassBoolean still breaks usage of sass-embedded as drop-in replacement, as mentioned by @rvock.
Originally posted by @guillaumerochelle in #337
The spec defines SassBoolean as a class, so this is indeed a bug in the Embedded Host's implementation of the Sass API.
The text was updated successfully, but these errors were encountered:
Goodwine
No branches or pull requests
Originally posted by @guillaumerochelle in #337
The spec defines
SassBoolean
as a class, so this is indeed a bug in the Embedded Host's implementation of the Sass API.The text was updated successfully, but these errors were encountered: