Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

setup.py files with package names which return functions that can't be resolved must be executed #251

Closed
techalchemy opened this issue Jun 1, 2020 · 0 comments · Fixed by #252
Labels
bug Something isn't working

Comments

@techalchemy
Copy link
Member

per pypa/pipenv#4292 -- a setup.py with a package name that points at a function, e.g. find_name(), that then opens and reads a file (i.e. the value can't be determined by the AST parser), must be executed instead of returning None.

If we return None, the package will never land in the Pipfile.lock.

@techalchemy techalchemy added the bug Something isn't working label Jun 1, 2020
techalchemy added a commit that referenced this issue Jun 1, 2020
techalchemy added a commit that referenced this issue Jun 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant