Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Requirement parse error when the name field is a function call #249

Closed
frostming opened this issue Jun 1, 2020 · 0 comments · Fixed by #250
Closed

Requirement parse error when the name field is a function call #249

frostming opened this issue Jun 1, 2020 · 0 comments · Fixed by #250

Comments

@frostming
Copy link
Member

frostming commented Jun 1, 2020 •
edited
Loading

Example setup.py:

def get_name():
    return 'foo'

setup(
    name=get_name(),
    ...
)

Requirement.from_line('-e .') produces: TypeError: expected string or bytes-like object

Original issue: pypa/pipenv#4292
@frostming frostming linked a pull request Jun 1, 2020 that will close this issue
Don't accept non-string values for name parsing #250
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Don't accept non-string values for name parsing sarugaku/requirementslib
1 participant
@frostming