Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Div and DivAssign is missing from some types (ComplexField and Scale<Rhs> with itself) #149

Open
TileHalo opened this issue Sep 3, 2024 · 1 comment · May be fixed by #150
Open

Div and DivAssign is missing from some types (ComplexField and Scale<Rhs> with itself) #149

TileHalo opened this issue Sep 3, 2024 · 1 comment · May be fixed by #150
Labels
enhancement New feature or request

Comments

@TileHalo
Copy link

TileHalo commented Sep 3, 2024

First, thanks for this excellent crate.

I am currently trying to implement custom algebraic field for Scale and I have ran into the problem that Scale does not implement Div<Scale<RhsE>> for Scale<LhsE> like it does for multiplication. Same applies with DivAssign. ComplexField too at least lacks these as prerequisites.

Is there a technical reason for this (i.e. is the simd implementation somehow blocking this) or is this just low on priority? If just low priority, I could implement these myself.
@TileHalo TileHalo added the enhancement New feature or request label Sep 3, 2024
@sarah-quinones
Copy link
Owner

just low priority, feel free to open a PR

@TileHalo TileHalo linked a pull request Sep 3, 2024 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Moved division to ComplexField and implemented Div for missing types. TileHalo/faer-rs
2 participants
@TileHalo @sarah-quinones