Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(arguments): enum argument #354

Merged
merged 3 commits into from
Jan 8, 2022
Merged

feat(arguments): enum argument #354

merged 3 commits into from
Jan 8, 2022

Conversation

sawa-ko
Copy link
Contributor

@sawa-ko sawa-ko commented Jan 7, 2022

A good argument.

@Lioness100
Copy link
Contributor

An option in context for making it case insensitive would be nice :D

@sawa-ko
Copy link
Contributor Author

sawa-ko commented Jan 7, 2022

@Lioness100 Done. :D

@Lioness100
Copy link
Contributor

Awesome :D

c43721
c43721 suggested changes Jan 7, 2022
View reviewed changes
src/lib/resolvers/enum.ts Show resolved Hide resolved
@favna
Copy link
Member

favna commented Jan 8, 2022

Can you also make a PR to https://github.com/sapphiredev/website to add it to the list of Built in arguments?

@sawa-ko sawa-ko mentioned this pull request Jan 8, 2022
Merged
@sawa-ko
Copy link
Contributor Author

sawa-ko commented Jan 8, 2022

@favna sapphiredev/website#124

@favna favna merged commit 9a0626c into sapphiredev:main Jan 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@c43721 c43721 c43721 approved these changes

@favna favna favna approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@sawa-ko @Lioness100 @favna @c43721