fix(Listener): fixed compile issues on TS 4.5 #329
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TS 4.5 no longer lets us compile @sapphire/framework when we have this generic the way we used to have it. Seeing as we have plans to fully remove the generic anyway in the next major release, we'll partially remove it for now by not reading it anywhere in the code, and having it extend `any`.
favna
force-pushed
the
fix/fixed-ts-4.5-compatibility
branch
from
197a445 to
f58fb39
Compare
favna
changed the title
vladfrangu
approved these changes
Nov 21, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a backport from the fix applied in
origin/trifecta-of-question-marks