Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

First mission in GTA VCS PSP is not playable with a custom main.scm #56

Closed
x87 opened this issue Aug 20, 2020 · 2 comments
Closed

First mission in GTA VCS PSP is not playable with a custom main.scm #56

x87 opened this issue Aug 20, 2020 · 2 comments
Labels
priority:p0 Critical Issue/Blocker scope:compiler type:bug Something isn't working workaround-available Users can fix for themselves
Milestone

Comments

@x87
Copy link
Collaborator

x87 commented Aug 20, 2020

Got a report that you can't get back to the army base in the first mission of GTA VCS. Investigating.

@x87 x87 added type:bug Something isn't working priority:p0 Critical Issue/Blocker scope:compiler status:in dev triage labels Aug 20, 2020
@x87
Copy link
Collaborator Author

x87 commented Aug 21, 2020

The issue is found. Both GTA LCS and GTA VCS use different numbering system for compound conditions. Previously the parameter in the IF instruction was off by 1 than the number of underlying conditions, now they match:

GTA 3, VC, SA:

if 1
 cond1
 cond2
jf

GTA LCS, GTA VCS:

if 2
  cond1
  cond2
jf

Feel dumb for not knowing that for so many years 😞 Learned it the hard way.

@x87
Copy link
Collaborator Author

x87 commented Aug 21, 2020

The issue is only reproducible with Check conditions on, as otherwise the disassembler keeps the IF number in place.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
priority:p0 Critical Issue/Blocker scope:compiler type:bug Something isn't working workaround-available Users can fix for themselves
Projects
None yet
Development

No branches or pull requests

1 participant