Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Label offsets in LCS/VCS does not match printed code offset #52

Closed
x87 opened this issue Aug 16, 2020 · 2 comments
Closed

Label offsets in LCS/VCS does not match printed code offset #52

x87 opened this issue Aug 16, 2020 · 2 comments
Labels
priority:p1 High Priority scope:disassembler type:bug Something isn't working workaround-available Users can fix for themselves
Milestone
v3.5.0

Comments

@x87
Copy link
Collaborator

x87 commented Aug 16, 2020

CODE_OFFSETS prints the actual file offset that is larger than the label offset at the same location by 8. It's hard to make CustomLabels.ini.
@x87 x87 added type:bug Something isn't working priority:p1 High Priority workaround-available Users can fix for themselves scope:disassembler labels Aug 16, 2020
@x87
Copy link
Collaborator Author

x87 commented Aug 16, 2020

this can be circumvented if offsets in the CustomLabels.ini are less by 8.

@x87 x87 added this to the v3.5 milestone Aug 16, 2020
@x87
Copy link
Collaborator Author

x87 commented Aug 16, 2020

fixed. CustomLabels.ini in LCS/VCS now matches CODE_OFFSETS

@x87 x87 mentioned this issue Aug 16, 2020
Closed
18 tasks
@x87 x87 closed this as completed Aug 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
priority:p1 High Priority scope:disassembler type:bug Something isn't working workaround-available Users can fix for themselves
Projects
None yet
Milestone
v3.5.0
Development

No branches or pull requests
1 participant
@x87