Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SAGXT.text Missing Entries and Tables #25

Closed
OrionSR opened this issue Apr 3, 2020 · 6 comments
Closed

SAGXT.text Missing Entries and Tables #25

OrionSR opened this issue Apr 3, 2020 · 6 comments
Labels
priority:p3 Low priority scope:doc Improvements or additions to documentation type:nice-to-have minor enhancements

Comments

@OrionSR
Copy link

OrionSR commented Apr 3, 2020

It was brought to my attention that the 3.3.3 version of SAGXT.text is missing the entry for FEM_OK that used to be included in older versions. The Public version appears to be the same. The two files are so different that it's not easy to compare the files for issues with other entries.

The entries are no longer sorted into their GXT tables. This makes this file considerably less useful than previous versions.

I'm not sure when the files changed or why.

@x87
Copy link
Collaborator

x87 commented Apr 5, 2020

I got this file from @ThirteenAG. I believe he was working on a side project and updated many previously unknown hashes. The update was also done for GTA 3 and VC.

@ThirteenAG
Copy link

https://github.com/ThirteenAG/GTA-One-Liners/blob/master/plugins/data/text/GTASA.text
I have FEM_OK here, but it might be possible this is a newer file.

The entries are no longer sorted into their GXT tables. This makes this file considerably less useful than previous versions.

I didn't have the use for GXT tables and they'd make the file harder to parse, so I got rid of them.
That's why I asked to keep old files here http://public.sannybuilder.com/GXT/old/
Because mine are a bit different.

@OrionSR
Copy link
Author

OrionSR commented Apr 5, 2020

Thanks AG. The file you linked looks much more complete than the version included with v3.3.3. Still, without the table references it's going to frustrate a lot of people when they don't work. Sanny's public documents are not well known to general users; maybe the older file should be included in the release files.

For reference, the issue was discovered when ZAZ was trying to answer a question on checking if a GXT entry was valid. I'm not sure what he had in mind but I worked out something that can do the job, but it will have problems if the strings are too long.

Is there a max limit for the string length?

@x87 x87 added priority:p3 Low priority scope:doc Improvements or additions to documentation type:nice-to-have minor enhancements labels Apr 11, 2020
@x87
Copy link
Collaborator

x87 commented Apr 11, 2020

Is there a max limit for the string length?

the limit to the string length in a GXT file is 2047.

@OrionSR
Copy link
Author

OrionSR commented May 26, 2020

https://github.com/Sergeanur/GXT/blob/master/SA%20PC/americanMission.txt

Serge's GXT text reference. Includes reference for tables. Not sure how it compares to the list from ThirteenAG.

@x87
Copy link
Collaborator

x87 commented Aug 3, 2020

I'm bringing back old GXT files with 3.4.0

@x87 x87 mentioned this issue Aug 3, 2020
13 tasks
@x87 x87 closed this as completed Aug 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
priority:p3 Low priority scope:doc Improvements or additions to documentation type:nice-to-have minor enhancements
Projects
None yet
Development

No branches or pull requests

3 participants