Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

⚠ Bug at Tools -> Make opcodes.txt #187

Closed
Tracked by #201
MatiDragon-YT opened this issue Mar 13, 2022 · 9 comments
Closed
Tracked by #201

⚠ Bug at Tools -> Make opcodes.txt #187

MatiDragon-YT opened this issue Mar 13, 2022 · 9 comments
Labels
priority:p3 Low priority scope:IDE type:bug Something isn't working
Milestone

Comments

@MatiDragon-YT
Copy link
Member

Executing the option does not update the opcodes.txt file.

@MatiDragon-YT MatiDragon-YT changed the title Bug at Tools -> Make opcodes.txt ⚠ Bug at Tools -> Make opcodes.txt Mar 13, 2022
@x87
Copy link
Collaborator

x87 commented Sep 2, 2022

Can you try running make_opcodes directly?
https://github.com/sannybuilder/make_opcodes

this is what Sanny Builder uses. Does this tool work for you?

@MatiDragon-YT
Copy link
Member Author

It does not work.
I've tried running it from the Git Bash terminal and from PowerShell, with the repository instructions and nothing happens

@x87
Copy link
Collaborator

x87 commented Sep 2, 2022

Maybe it is sensitive to the file names? Can you try running it from another directory?
Also try running as admin.

If you can share a video of you running it, it may help me to suggest further steps.

@MatiDragon-YT
Copy link
Member Author

Sorry for the delay in responding.

I just tested it on two different terminals (GitBash and PowerShell) and at first neither worked with a cleo script source code. Then I tried it with the code that is generated by decompiling the main.scm of SA, and there if it worked, although I do not know well... I would say that in part... hahaha

Also I just noticed that there is no documentation about this tool in the CHM, it would be good to indicate that the tool cannot generate a complete list, if there are KEYWORDS or CLASSES in it.

But anyway, the tool still does not generate the list of opcodes if I run it from the IDE.

bandicam.2022-09-06.11-14-39-165.mp4

@x87
Copy link
Collaborator

x87 commented Sep 6, 2022

it would be good to indicate that the tool cannot generate a complete list, if there are KEYWORDS or CLASSES in it.

it needs keywords list and/or classes.db to identify that a word is a keyword or a class (e.g. wait 0). Use --keywords and --classes params to provide those files to the tool.

make_opcodes.exe script.txt --output opcodes.txt --keywords ..\data\sa\keywords.txt --classes ..\data\sa\classes.db 

But anyway, the tool still does not generate the list of opcodes if I run it from the IDE.

do you see anything at all? flashing window, running process, any files generated (even empty). Do you run Sanny as admin?

@MatiDragon-YT
Copy link
Member Author

do you see anything at all? flashing window, running process, any files generated (even empty). Do you run Sanny as admin?

Without running it as administrator, nothing comes out. Only SB freezes for a short moment.
And running as administrator, the Windows window appears, that a file is being copied, but when checking the opcodes file, it is not updated, and if I delete it, it is not created.

@x87 x87 added type:bug Something isn't working priority:p3 Low priority scope:IDE and removed status:in dev triage labels Sep 7, 2022
@x87
Copy link
Collaborator

x87 commented Sep 7, 2022

Thanks for helping me to triage this issue. I think I found the root cause. Please stay tuned, should be resolved with the next update.

@x87 x87 added this to the Next milestone Sep 7, 2022
@x87 x87 mentioned this issue Sep 8, 2022
2 tasks
@x87
Copy link
Collaborator

x87 commented Sep 8, 2022

@MatiDragon-YT please check version 3.8.2 and confirm the fix

@MatiDragon-YT
Copy link
Member Author

@x87 It works very well 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
priority:p3 Low priority scope:IDE type:bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants