Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

String variable constants are not highlighted #140

Closed
Tracked by #130
wmysterio opened this issue May 10, 2021 · 7 comments
Closed
Tracked by #130

String variable constants are not highlighted #140

wmysterio opened this issue May 10, 2021 · 7 comments
Labels
priority:p3 Low priority scope:IDE type:nice-to-have minor enhancements
Milestone

Comments

@wmysterio
Copy link

{$CLEO .cs}
0000:

const

handle = 10@

my_strs1 = 20@s   
my_strs2 = s$str

my_strv1 = 6@v
my_strv2 = v$str

end

0A93: terminate_this_custom_script

@x87
Copy link
Collaborator

x87 commented May 10, 2021

@wmysterio Do you expect my_str* to be blue (as variables) or red (as strings)?

@wmysterio
Copy link
Author

@x87 This is a report from Vital. As far as I understood, blue is expected. Color for variables, as in handle = 10@ case.

@VitalRus95
Copy link

Sorry for having @wmysterio send this report instead of me, I was rather busy and only got rid of some routine now.
I may add that not only string constants, but also expressions constants are not highlighted, both in semantic and non-semantic modes. As for the colour, I expect it to follow the highlighting mode: if it's the semantic one, then strings should be the string colour if it's possible.

How the issue looks in my case:
изображение

@x87 x87 added priority:p3 Low priority scope:IDE type:nice-to-have minor enhancements labels May 10, 2021
@x87
Copy link
Collaborator

x87 commented May 10, 2021

@VitalRus95 try with this version (unzip to SB\lib)
core.zip

sanny should highlight them as variables (blue).

expressions constants are not highlighted

they probably should not. what color do you expect?

@VitalRus95
Copy link

@x87, thank you, that makes the highlighter see the string constants! Now I also can select them from the list (Ctrl+Space), and I wasn't able to before your fix.
As for expressions constants, they are still not highlighted at all and not present in the pop-up list. If possible, I think the colour can match the class commands' colour. Thank you once again for your help!

изображение

@x87 x87 mentioned this issue May 15, 2021
48 tasks
@x87 x87 added this to the v3.8.0 milestone Jun 6, 2021
@x87 x87 closed this as completed Jun 9, 2021
@x87
Copy link
Collaborator

x87 commented Jun 9, 2021

expressions constants, they are still not highlighted at all and not present in the pop-up list.

to be fair, I think this is a quirk in the language and should be avoided. By no means actor.Angle(plr) is a constant.

@wmysterio
Copy link
Author

By no means actor.Angle(plr) is a constant.

This entry looks more like some kind of macro than a constant in the usual sense.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
priority:p3 Low priority scope:IDE type:nice-to-have minor enhancements
Projects
None yet
Development

No branches or pull requests

3 participants