Skip to content

Commit e5332ca

Browse files
rexxarsbjoerge
authored andcommitted
[client] Make node-specific middleware be excluded from bundles (#164)
1 parent 968c39b commit e5332ca

File tree

4 files changed

+20
-14
lines changed

4 files changed

+20
-14
lines changed

packages/@sanity/client/package.json

+4
Original file line numberDiff line numberDiff line change
@@ -16,6 +16,10 @@
1616
"prepublish": "in-publish && npm run build || not-in-publish",
1717
"test": "NODE_ENV=test tape -r babel-register test/*.test.js"
1818
},
19+
"browser": {
20+
"./src/http/nodeMiddleware.js": "./src/http/browserMiddleware.js",
21+
"./lib/http/nodeMiddleware.js": "./lib/http/browserMiddleware.js"
22+
},
1923
"dependencies": {
2024
"@sanity/eventsource": "^0.111.5",
2125
"@sanity/generate-help-url": "^0.111.5",
Original file line numberDiff line numberDiff line change
@@ -0,0 +1 @@
1+
module.exports = []
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,10 @@
1+
const debug = require('get-it/lib/middleware/debug')
2+
const headers = require('get-it/lib/middleware/headers')
3+
const pkg = require('../../package.json')
4+
5+
const middleware = [
6+
debug({verbose: true, namespace: 'sanity:client'}),
7+
headers({'User-Agent': `${pkg.name} ${pkg.version}`})
8+
]
9+
10+
module.exports = middleware

packages/@sanity/client/src/http/request.js

+5-14
Original file line numberDiff line numberDiff line change
@@ -20,25 +20,16 @@ const httpError = ({
2020
}
2121
})
2222

23-
const middleware = [
23+
// Environment-specific middleware.
24+
const envSpecific = require('./nodeMiddleware')
25+
26+
const middleware = envSpecific.concat([
2427
jsonRequest(),
2528
jsonResponse(),
2629
progress(),
2730
httpError,
2831
observable({implementation: SanityObservable})
29-
]
30-
31-
// Node-specifics
32-
if (process.env.BROWSERIFY_ENV !== 'build') {
33-
// Only include debug middleware in browsers
34-
const debug = require('get-it/lib/middleware/debug')
35-
middleware.unshift(debug({verbose: true, namespace: 'sanity:client'}))
36-
37-
// Assign user agent in node
38-
const headers = require('get-it/lib/middleware/headers')
39-
const pkg = require('../../package.json')
40-
middleware.unshift(headers({'User-Agent': `${pkg.name} ${pkg.version}`}))
41-
}
32+
])
4233

4334
const request = getIt(middleware)
4435

0 commit comments

Comments
 (0)