diff --git a/.npmignore b/.npmignore deleted file mode 100644 index dd853a4b..00000000 --- a/.npmignore +++ /dev/null @@ -1,9 +0,0 @@ -/.github -/.editorconfig -/.eslintrc -/.gitignore -/.prettierrc -/.taprc -/coverage -/test -.nyc_output diff --git a/README.md b/README.md index 029975e1..d4268192 100644 --- a/README.md +++ b/README.md @@ -239,7 +239,7 @@ If the plugin is shared across multiple "private" studios: register an organizat Also; you cannot easily remove modules/versions from npm once published. Take a good look at your `package.json` to see that the fields in there makes sense to you, and make sure there are no "secrets" (authorization tokens, API keys or similar) in the plugin directory - -anything not listed in `.npmignore` will be part of the published module. +any files within folders defined in the `files` field inside `package.json` will be included with your module. When you're ready to publish, run `npm publish` (or `yarn publish` if you prefer). The `prepublishOnly` task should kick in and compile the source files, then verify the built output to ensure it looks good. diff --git a/assets/inject/npmignore b/assets/inject/npmignore deleted file mode 100644 index 3b109af8..00000000 --- a/assets/inject/npmignore +++ /dev/null @@ -1,9 +0,0 @@ -/test -/coverage -.editorconfig -.eslintrc -.gitignore -.github -.prettierrc -.travis.yml -.nyc_output diff --git a/src/actions/inject.ts b/src/actions/inject.ts index 944622dc..82506342 100644 --- a/src/actions/inject.ts +++ b/src/actions/inject.ts @@ -346,7 +346,6 @@ async function writeStaticAssets(options: InjectOptions) { const files: FromTo[] = [ {from: 'editorconfig', to: '.editorconfig'}, - {from: 'npmignore', to: '.npmignore'}, {from: 'sanity.json', to: 'sanity.json'}, {from: 'v2-incompatible.js.template', to: 'v2-incompatible.js'}, { diff --git a/test/fixtures/inject/valid/.npmignore b/test/fixtures/inject/valid/.npmignore deleted file mode 100644 index 3b109af8..00000000 --- a/test/fixtures/inject/valid/.npmignore +++ /dev/null @@ -1,9 +0,0 @@ -/test -/coverage -.editorconfig -.eslintrc -.gitignore -.github -.prettierrc -.travis.yml -.nyc_output diff --git a/test/fixtures/verify-package/every-failure-possible/.npmignore b/test/fixtures/verify-package/every-failure-possible/.npmignore deleted file mode 100644 index 3b109af8..00000000 --- a/test/fixtures/verify-package/every-failure-possible/.npmignore +++ /dev/null @@ -1,9 +0,0 @@ -/test -/coverage -.editorconfig -.eslintrc -.gitignore -.github -.prettierrc -.travis.yml -.nyc_output diff --git a/test/fixtures/verify-package/fresh-v2-movie-studio/.npmignore b/test/fixtures/verify-package/fresh-v2-movie-studio/.npmignore deleted file mode 100644 index 3bc18c38..00000000 --- a/test/fixtures/verify-package/fresh-v2-movie-studio/.npmignore +++ /dev/null @@ -1,12 +0,0 @@ -# Logs -/logs -*.log - -# Coverage directory used by tools like istanbul -/coverage - -# Dependency directories -node_modules - -# Compiled sanity studio -/dist diff --git a/test/fixtures/verify-package/invalid-eslint/.npmignore b/test/fixtures/verify-package/invalid-eslint/.npmignore deleted file mode 100644 index 3b109af8..00000000 --- a/test/fixtures/verify-package/invalid-eslint/.npmignore +++ /dev/null @@ -1,9 +0,0 @@ -/test -/coverage -.editorconfig -.eslintrc -.gitignore -.github -.prettierrc -.travis.yml -.nyc_output diff --git a/test/fixtures/verify-package/valid/.npmignore b/test/fixtures/verify-package/valid/.npmignore deleted file mode 100644 index 3b109af8..00000000 --- a/test/fixtures/verify-package/valid/.npmignore +++ /dev/null @@ -1,9 +0,0 @@ -/test -/coverage -.editorconfig -.eslintrc -.gitignore -.github -.prettierrc -.travis.yml -.nyc_output diff --git a/test/init.test.ts b/test/init.test.ts index f6de8ce9..bdb35668 100644 --- a/test/init.test.ts +++ b/test/init.test.ts @@ -61,7 +61,6 @@ tap.test('plugin-kit init --force in empty directory', async (t) => { 'lint-staged.config.js', '*.js' ) - await fileContains('.npmignore', '/test') await fileContains('.prettierrc.js', 'semi: false') await fileContains('sanity.json', '"path": "./v2-incompatible.js"') await fileContains('v2-incompatible.js', 'showIncompatiblePluginDialog')