New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ambiguity with null variable values and default values #359

Closed

OlegIlyenko opened this issue Apr 16, 2018 · 1 comment

Labels

spec-change verify

Milestone

Member

OlegIlyenko commented Apr 16, 2018

In general, I think the sangria's behaviour should comply with the spec changes. But just to be 100% sure, this needs to be verified in detail.

spec: graphql/graphql-spec#418
ref. impl.: graphql/graphql-js#1274

OlegIlyenko added future-spec-change verify labels

OlegIlyenko added this to the Backlog milestone

OlegIlyenko modified the milestones: Backlog, v1.4.1

OlegIlyenko added spec-change and removed future-spec-change labels

OlegIlyenko closed this as completed in

60be110

Member Author

OlegIlyenko commented May 11, 2018

There were some changes to the validations, but no significant changes to the actual logic that handles null and default values.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment