[Scala 3 migration] Replace empty sealed trait with an opaque type in Scala 3 #132
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes an issue with A.asInstanceOf[A with B] throwing cast exceptions in Scala 3 if B was an empty sealed trait. From a users perspective the API should not change.
yanns
approved these changes
Jun 25, 2022
Contributor
yanns
left a comment
yanns
left a comment
There was a problem hiding this comment.
This look good, thanks a lot!
Contributor
|
A small issue with scalafmt: https://github.com/sangria-graphql/sangria-marshalling-api/runs/7055347676?check_suite_focus=true |
Contributor
Author
|
I've updated the scalafmt config and it seems to be ok now (sorry for the late response) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of an ongoing effort to migrate sangria to Scala 3.
This PR fixes an issue with A.asInstanceOf[A with B] (and operation on which the tagging mechanism is based on) throwing cast exceptions in Scala 3 if B was an empty sealed trait. This was replaced with and empty opaque type serving basically the same purpose. From a users perspective the API itself should not change. I discovered this issue when running code in the main sangria project, here in isolation that code is not run and therefore the problem does not appear.