Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Y24-301 - Refactor the run store for the ONT pipeline to switch from Axios to Fetch and to use test factories. #1919

Closed
seenanair opened this issue Sep 5, 2024 · 0 comments · Fixed by #1918
Closed

Y24-301 - Refactor the run store for the ONT pipeline to switch from Axios to Fetch and to use test factories. #1919

seenanair opened this issue Sep 5, 2024 · 0 comments · Fixed by #1918
Assignees
@seenanair
Labels
Size: M Medium - medium effort & risk Traction Stories related to Traction application Value: 3 Value to the insitute is average

Comments

@seenanair
Copy link
Contributor

Describe the Housekeeping

  • Move all requests in the ontRuns and ontRoot stores from Axios to Fetch.
  • Create test factories for data used in tests related to ontRuns and ontRoot.
  • Replace test files with test factories in all relevant tests.
  • Remove data and fixture files.

Blocking issues
Describe any other issues or tickets that may be blocking this change.

Additional context
Add any other context about the problem here.
#1767
@seenanair seenanair added Size: M Medium - medium effort & risk Value: 3 Value to the insitute is average Traction Stories related to Traction application labels Sep 5, 2024
@psd-issuer psd-issuer bot changed the title Refactor the OntRun store to switch from Axios to Fetch and use test factories. Y24-301 - Refactor the OntRun store to switch from Axios to Fetch and use test factories. Sep 5, 2024
@seenanair seenanair changed the title Y24-301 - Refactor the OntRun store to switch from Axios to Fetch and use test factories. Y24-301 - Refactor the run store for the ONT pipeline to switch from Axios to Fetch and to use test factories. Sep 5, 2024
@seenanair seenanair self-assigned this Sep 5, 2024
@seenanair seenanair mentioned this issue Sep 5, 2024
Merged
@seenanair seenanair linked a pull request Sep 5, 2024 that will close this issue
Y24-160 ont runs axios to fetch #1918
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@seenanair seenanair

Labels
Size: M Medium - medium effort & risk Traction Stories related to Traction application Value: 3 Value to the insitute is average
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Y24-160 ont runs axios to fetch sanger/traction-ui
1 participant
@seenanair