Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

404s are not nice formatted #25

Open
xet7 opened this issue Mar 8, 2018 · 1 comment
Open

404s are not nice formatted #25

xet7 opened this issue Mar 8, 2018 · 1 comment

Comments

@xet7
Copy link
Member

xet7 commented Mar 8, 2018

From @JamborJan on February 26, 2017 20:30

Usually templates offer nice formatted 404 error pages including the possebility to incude a search form etc. Unfortunately the sandstorm version doesn't have that.

I'm not quite at the point where I can nail down the root cause but I will try to find something.

@dwrensha can you maybe please add some intsruction to README.md so that I can make a build to test my changes?

What you get today when you open a not existing URL like mydomain.com/something/wrong:
bildschirmfoto 2017-02-26 um 21 33 46

What you might want (example):
bildschirmfoto 2017-02-26 um 21 30 43

Copied from original issue: dwrensha/wordpress-sandstorm#31

@xet7
Copy link
Member Author

xet7 commented Mar 8, 2018

From @dwrensha on March 6, 2017 23:25

Sandstorm does not currently provide a way for apps to specify custom 404 pages. In case you're curious, the code that servers the 404 right now is: https://github.com/sandstorm-io/sandstorm/blob/v0.204/shell/server/pre-meteor.js#L133-L145. In theory it would be possible to enhance Sandstorm's current hacky web publishing feature to allow custom 404 pages. The longer-term plan is to use the interfaces described in web-publishing.capnp. In particular, it describes a notion of "not-found entities": https://github.com/sandstorm-io/sandstorm/blob/v0.204/src/sandstorm/web-publishing.capnp#L77-L79.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant