Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Meteor 1.9 doesn't work at all #3189

Closed
kentonv opened this issue Jan 19, 2020 · 10 comments · Fixed by #3269
Closed

Meteor 1.9 doesn't work at all #3189

kentonv opened this issue Jan 19, 2020 · 10 comments · Fixed by #3269
Labels
sandstorm-dev Issues hacking on Sandstorm

Comments

@kentonv
Copy link
Member

kentonv commented Jan 19, 2020

Just trying to update to Meteor 1.9 fails with C++ compiler errors, apparently due to node-sass not being able to build against Node 12. To reproduce:

cd shell
meteor update

It errors out with no changes having been made.

Not sure where to start with this. Surely node-sass has been updated for Node 12? Do we need to update the package somehow before we update Meteor? How?

@xet7
Copy link
Contributor

xet7 commented Jan 19, 2020

Wekan currently uses Meteor 1.9, only errors I see are about Node 12 changes about new Buffer( changing to Buffer.alloc() etc. You could look at Wekan dependencies:
https://github.com/wekan/wekan/tree/master/.meteor

@xet7
Copy link
Contributor

xet7 commented Jan 19, 2020

For Meteor 1.9, I usually do this:

sudo npm -g install npm
sudo npm -g install n
sudo n 12.14.1
sudo npm -g uninstall node-gyp node-pre-gyp fibers
sudo npm -g install node-gyp node-pre-gyp fibers

@xet7
Copy link
Contributor

xet7 commented Jan 19, 2020

And maybe also:

sudo node-gyp rebuild

@xet7
Copy link
Contributor

xet7 commented Jan 19, 2020

Just in case, here is also a script I use to convert Wekan x64 bundle to RasPi3/4 arm64 bundle:
https://releases.wekan.team/raspi3/maintainer-make-bundle.sh

@kentonv
Copy link
Member Author

kentonv commented Jan 26, 2020

@xet7 I'm sure Meteor 1.9 works for some apps, otherwise it wouldn't have been released. :) But Sandstorm itself currently cannot be updated to Meteor 1.9 for some reason. Need to investigate more.

@ocdtrekkie ocdtrekkie added the sandstorm-dev Issues hacking on Sandstorm label Feb 12, 2020
@kentonv
Copy link
Member Author

kentonv commented Mar 14, 2020

It looks like the problem is that we're still on node-sass 3.x. 4.x was released several years ago but Meteor assumes major version number increases are backwards-incompatible. It does appear that node-sass has continued to update the 3.x branch in the meantime, but it hasn't been updated for node12? I can't tell if there's actually any incompatibility expected in the upgrade, though.

So I'm going to bump us to 4.x an hope nothing breaks...

@kentonv
Copy link
Member Author

kentonv commented Mar 14, 2020

That seems to work, and now I can upgrade to Meteor 1.9.x. New problem: node12 insists on querying disk files using the new statx() syscall which it invokes directly which bypasses ekam's syscall rewriting, so the node-capnp test spuriously fails... ugh

@xet7
Copy link
Contributor

xet7 commented Mar 14, 2020

@kentonv

Thanks a lot for trying to upgrade! I'm also currently upgrading Wekan dependencies.

@kentonv
Copy link
Member Author

kentonv commented Mar 15, 2020

Solved statx() with: capnproto/ekam#30

New problem: node12 breaks fibers: nodejs/node#29767

Meteor worked around it with a flag: meteor/meteor@c37bab6

I guess I can do that too.

@kentonv
Copy link
Member Author

kentonv commented Mar 15, 2020

Ughhhh... the pinned version of the icon-font-builder code doesn't work with node 12. If I update to latest versions, they produce broken fonts. Whyyyyyyyyy?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
sandstorm-dev Issues hacking on Sandstorm
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants