Skip to content

Fix memory management for OpenVINO init #397

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
sandrohanea merged 1 commit into from
Jun 13, 2025
Merged

Fix memory management for OpenVINO init #397

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion Whisper.net/WhisperFactory.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -67,7 +67,8 @@ private WhisperFactory(IWhisperProcessorModelLoader loader, bool delayInit)

var systemInfoPtr = libraryLoaded.Value.NativeWhisper!.WhisperPrintSystemInfo();
var systemInfoStr = Marshal.PtrToStringAnsi(systemInfoPtr);
Marshal.FreeHGlobal(systemInfoPtr);
// The pointer returned by WhisperPrintSystemInfo points to a static
// buffer owned by the native library. Do not free it here.
return systemInfoStr;
}

Expand Down
34 changes: 22 additions & 12 deletions Whisper.net/WhisperProcessor.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -357,18 +357,28 @@ private unsafe Task ProcessInternalAsync(ReadOnlyMemory<float> samples, Cancella
private IntPtr GetWhisperState()
{
var state = nativeWhisper.Whisper_Init_State(currentWhisperContext);
if (RuntimeOptions.LoadedLibrary == RuntimeLibrary.OpenVino)
{
var modelPath = Marshal.StringToHGlobalAnsi(options.OpenVinoModelPath);
var device = Marshal.StringToHGlobalAnsi(options.OpenVinoDevice);
var cachePath = Marshal.StringToHGlobalAnsi(options.OpenVinoCacheDir);
nativeWhisper.Whisper_Ctx_Init_Openvino_Encoder_With_State(
options.ContextHandle,
state,
modelPath,
device,
cachePath);
}
if (RuntimeOptions.LoadedLibrary == RuntimeLibrary.OpenVino)
{
var modelPath = Marshal.StringToHGlobalAnsi(options.OpenVinoModelPath);
var device = Marshal.StringToHGlobalAnsi(options.OpenVinoDevice);
var cachePath = Marshal.StringToHGlobalAnsi(options.OpenVinoCacheDir);

try
{
nativeWhisper.Whisper_Ctx_Init_Openvino_Encoder_With_State(
options.ContextHandle,
state,
modelPath,
device,
cachePath);
}
finally
{
Marshal.FreeHGlobal(modelPath);
Marshal.FreeHGlobal(device);
Marshal.FreeHGlobal(cachePath);
}
}
return state;
}

Expand Down
Loading