Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecation of DenseOperatorInterface #447

Open
coreyostrove opened this issue Jun 4, 2024 · 0 comments
Open

Deprecation of DenseOperatorInterface #447

coreyostrove opened this issue Jun 4, 2024 · 0 comments
Assignees
Labels
enhancement Request for a new feature or a change to an existing feature
Milestone

Comments

@coreyostrove
Copy link
Contributor

This issue is meant to track progress on the process of deprecating and removing the DenseOperatorInterface for model members.
The DenseOperatorInterface is a class which certain process matrix-like model members (such as FullArbitraryOp or FullTPOp) inherit from which allows for interacting with them using a numpy-like API (i.e. as if they were simply numpy arrays). We have identified some problematic aspects of this design, including its connection to the bug reported in #397. Additionally, this creates a bifurcation in the API for model members where in some instance one can interact with an object like an array, but some other model members require the use of methods such as to_dense and set_dense etc. to interact with their contents. There are benefits to the simplicity of having a single unified API, including maintainability and readability.

Given that we have made the tentative decision to remove this functionality, with it being officially deprecated in 0.9.13 and slated for removal in 0.9.14. We are, of course, open to feedback on this decision. So if there is sufficient push back to this we can reevaluate whether it makes sense to proceed with the removal.

@coreyostrove coreyostrove added the enhancement Request for a new feature or a change to an existing feature label Jun 4, 2024
@coreyostrove coreyostrove added this to the 0.9.13 milestone Jun 4, 2024
@coreyostrove coreyostrove self-assigned this Jun 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Request for a new feature or a change to an existing feature
Projects
None yet
Development

No branches or pull requests

1 participant