Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make warning (catching polymorphic type) in jid-reader.cpp #23

Open
michaeldsmith opened this issue Feb 15, 2021 · 0 comments
Open

make warning (catching polymorphic type) in jid-reader.cpp #23

michaeldsmith opened this issue Feb 15, 2021 · 0 comments

Comments

@michaeldsmith
Copy link

building with latest master on Ubuntu, I get this warning in jid-reader.cpp

[ 62%] Building CXX object CMakeFiles/jid-reader.dir/src/main/jid-reader.cpp.o
/mnt/c/data/software/jid/src/main/jid-reader.cpp: In function ‘int main(int, const char**)’:
/mnt/c/data/software/jid/src/main/jid-reader.cpp:285:54: warning: catching polymorphic type ‘class boost::program_options::required_option’ by value [-Wcatch-value=]
  285 |     } catch (boost::program_options::required_option e) {
      |                                                      ^
/mnt/c/data/software/jid/src/main/jid-reader.cpp:290:33: warning: catching polymorphic type ‘class std::runtime_error’ by value [-Wcatch-value=]
  290 |     } catch (std::runtime_error e) {
      |                                 ^
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant