-
Notifications
You must be signed in to change notification settings - Fork 19
URL resolver shouldn't be managing its own prepending #58
Comments
I suspect this is related: #22 |
@bcardarella I've made some changes to the addon and dropped the rename feature that was causing more problems than giving real benefits. You can see these changes in PR #59. Can you check if these changes fixes the issues you're facing? If this PR doesn't fix the problems, Can you add a bit more info what |
I feel you're still working outside of ember-cli. Why not just add the necessary files to the |
@bcardarella can you expand a bit the idea? I'm trying to use ember-cli as much as possible and let ember-cli to handle the fingerprinting with broccoli-asset-rev. There are some "things" I have to do because they are not done automatically by ember-cli, like using the Another feature that this addon brings is that it configures broccoli-asset-rev to process images inside Maybe there's something the addon is doing that can be avoided, I'm more than glad on removing/refactor that but It's not clear to me what would that be. Really appreciate you looking into how the addon work and the feedback 😃 |
@san650 no worries, we are making use of it so I'm happy to provide feedback :) |
I'll close this issue for now, feel free to reopen it if you have more info about it. |
ember-cli will compose all the URLs you need, there isn't any need to manage this within
ember-web-app
: https://github.com/san650/ember-web-app/blob/master/lib/apple-link-tags.js#L34When allowing ember-cli to handle the URL composition you end up with values like this:
<link rel="apple-touch-icon" href="https://assets.dockyard.com/https://assets.dockyard.com/assets/images/badge192-5bfe81121b638c30dc2fe97375428477.png" sizes="192x192">
The text was updated successfully, but these errors were encountered: