Add optimistic_lock_token to valkyrie resources on query #475
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hackartisan
changed the title
tpendragon
requested changes
Jul 30, 2018
| context "without locking enabled" do | ||
| before do | ||
| class CustomNonlockingResource < Valkyrie::Resource | ||
| enable_optimistic_locking |
There was a problem hiding this comment.
I thought locking wasn't supposed to be enabled?
| resource = persister.save(resource: CustomNonlockingResource.new(title: "My Title")) | ||
| resource = query_service.find_by(id: resource.id) | ||
| query_doc = (query_service.connection.get 'select', :params => {:q => "id:#{resource.id}"})["response"]["docs"].first | ||
| expect(resource.optimistic_lock_token.first).to eq query_doc["_version_"] |
There was a problem hiding this comment.
This should be checking to make sure this isn't set right? Or even that the property doesn't exist I guess.
tpendragon
requested changes
Jul 30, 2018
| resource = persister.save(resource: CustomNonlockingResource.new(title: "My Title")) | ||
| resource = query_service.find_by(id: resource.id) | ||
| query_doc = (query_service.connection.get 'select', params: { q: "id:#{resource.id}" })["response"]["docs"].first | ||
| expect(resource.optimistic_lock_token.first).to eq query_doc["_version_"] |
There was a problem hiding this comment.
Shouldn't this not exist?
There was a problem hiding this comment.
yeah it looks like this is actually covered by the resource spec in https://github.com/samvera-labs/valkyrie/pull/474/files
There was a problem hiding this comment.
so we'll just remove that test here.
connected to #286 connected to #453 Co-authored-by: Adam Wead <[email protected]> Co-authored-by: Michael Tribone <[email protected]>
tpendragon
approved these changes
Jul 30, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We'll deal with the fact that these aren't coming through from the persister in a forthcoming (persister-focused) PR
connected to #286
connected to #453