Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fedora oportunistic locking should also use Fedora's If-Unmodified-Since support #522

Closed
escowles opened this issue Aug 6, 2018 · 1 comment
Closed

Fedora oportunistic locking should also use Fedora's If-Unmodified-Since support #522

escowles opened this issue Aug 6, 2018 · 1 comment
Assignees
@escowles
Labels
enhancement

Comments

@escowles
Copy link
Contributor

escowles commented Aug 6, 2018 •
edited
Loading

This will prevent overwriting updates from non-Valkyrie clients

Refs #454, #286
@escowles escowles mentioned this issue Aug 6, 2018
Merged
@escowles
Copy link
Contributor Author

escowles commented Aug 6, 2018

We are already passing a block to set custom headers in the Fedora persister:
https://github.com/samvera-labs/valkyrie/blob/21613159d7dc7cd5562194ccb1308b080d16d07c/lib/valkyrie/persistence/fedora/persister.rb#L26

We should be able to get the timestamp from the lock token, and pass the date in the If-Unmodified-Sinceheader there.

@escowles escowles self-assigned this Aug 6, 2018
@escowles escowles added in progress and removed ready labels Aug 6, 2018
@escowles escowles mentioned this issue Aug 6, 2018
Closed
This was referenced Aug 7, 2018
Closed
Merged
@awead awead closed this as completed in #556 Aug 9, 2018
@awead awead removed the Review label Aug 9, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@escowles escowles

Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@awead @escowles