Support Field in dataclass + 'metadata' kwarg of dataclasses.field
#2384
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ield` Please enter the commit message for your changes. Lines starting
Codecov Report
@@ Coverage Diff @@
## master #2384 +/- ##
=======================================
Coverage 99.90% 99.90%
=======================================
Files 25 25
Lines 5039 5051 +12
Branches 1031 1034 +3
=======================================
+ Hits 5034 5046 +12
Misses 1 1
Partials 4 4
Continue to review full report at Codecov.
|
PrettyWood
force-pushed
the
f/dataclasses-field
branch
from
cb3000c to
149b10c
Compare
| default=None, | ||
| metadata=dict(title='The age of the user', description='do not lie!') | ||
| ) | ||
| height: Optional[int] = Field(None, title='The height in cm', ge=50, le=300) |
pydantic/dataclasses.py
Outdated
|
|
||
| # We need to remove `FieldInfo` values since they are not valid as input | ||
| # It's ok since they are obviously the default values | ||
| input_data = {k: v for k, v in self.__dict__.items() if not isinstance(v, FieldInfo)} |
There was a problem hiding this comment.
Humm, I wonder if this will have an adverse effect on performance?
Perhaps we could add a flag somehow below when any fields use Field, then only run this logic if so?
There was a problem hiding this comment.
relevant commit fb97e08
samuelcolvin
added
the
awaiting author revision
PrettyWood
added
ready for review
and removed
awaiting author revision
This was referenced Mar 6, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change Summary
When we use pydantic
dataclass, we are limited by currentdataclasses.fieldto declare a field.Now we can either use
Fieldlike for aBaseModelor leveragedataclasses.fieldby using the'metadata'kwargRelated issue number
closes #470
closes #2382
Checklist
changes/<pull request or issue id>-<github username>.mdfile added describing change(see changes/README.md for details)