Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TabixIndex.writeBasedOnFeaturePath should throw instead of silently Failing #821

Open
lbergelson opened this issue Mar 9, 2017 · 0 comments
Open

TabixIndex.writeBasedOnFeaturePath should throw instead of silently Failing #821

lbergelson opened this issue Mar 9, 2017 · 0 comments

Comments

@lbergelson
Copy link
Member

lbergelson commented Mar 9, 2017 •
edited
Loading

currently if TabixIndex.writeBasedOnFeatureFile or the upcoming writeBasedOnFeaturePath will silently fail to write an index in the case where the path is not a RegularFile. This seems like it should throw TribbleException instead.

We should test this change against picard/gatk to see if there's some code that's somehow relying on this behavior before committing the change.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@lbergelson